Change in coreboot[master]: soc/amd/picasso: Fix the typo in GPIO define

[Bao Zheng (Code Review)]

Hello Zheng Bao,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48633

to review the following change.

Change subject: soc/amd/picasso: Fix the typo in GPIO define
......................................................................

soc/amd/picasso: Fix the typo in GPIO define

Change-Id: I8c9eed5d0e320b02382c24304a44e51e89eb6ac5
Signed-off-by: Zheng Bao 
---
M src/soc/amd/picasso/include/soc/gpio.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/48633/1

diff --git a/src/soc/amd/picasso/include/soc/gpio.h b/src/soc/amd/picasso/include/soc/gpio.h
index 4fbb937..e68d2fd 100644
--- a/src/soc/amd/picasso/include/soc/gpio.h
+++ b/src/soc/amd/picasso/include/soc/gpio.h
@@ -146,7 +146,7 @@
 #define GPIO_21_IOMUX_EMMC_CMD 1
 #define GPIO_21_IOMUX_GPIOxx 2
 #define GPIO_22_IOMUX_LPC_PME_L 0
-#define GPIO_22_IOMUX_EMMC_PRW_CTRL 1
+#define GPIO_22_IOMUX_EMMC_PWR_CTRL 1
 #define GPIO_22_IOMUX_GPIOxx 2
 #define GPIO_23_IOMUX_AC_PRES 0
 #define GPIO_23_IOMUX_SGPIO_LOAD 1

[Bao Zheng (Code Review)]

Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Zheng Bao, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48633

to look at the new patch set (#2).

Change subject: soc/amd/picasso: Fix the typo in GPIO define
......................................................................

soc/amd/picasso: Fix the typo in GPIO define

Change-Id: I8c9eed5d0e320b02382c24304a44e51e89eb6ac5
Signed-off-by: Zheng Bao 
---
M src/mainboard/amd/mandolin/emmc_gpio.c
M src/mainboard/amd/mandolin/variants/cereme/early_gpio.c
M src/mainboard/amd/mandolin/variants/mandolin/early_gpio.c
M src/soc/amd/picasso/include/soc/gpio.h
4 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/48633/2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48633 )

Change subject: soc/amd/picasso: Fix the typo in GPIO define
......................................................................

Patch Set 2: Code-Review+2

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48633 )

Change subject: soc/amd/picasso: Fix the typo in GPIO define
......................................................................

Patch Set 2: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48633 )

Change subject: soc/amd/picasso: Fix the typo in GPIO define
......................................................................

soc/amd/picasso: Fix the typo in GPIO define

Change-Id: I8c9eed5d0e320b02382c24304a44e51e89eb6ac5
Signed-off-by: Zheng Bao 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48633
Tested-by: build bot (Jenkins) 
Reviewed-by: Frans Hendriks 
Reviewed-by: Felix Held 
---
M src/mainboard/amd/mandolin/emmc_gpio.c
M src/mainboard/amd/mandolin/variants/cereme/early_gpio.c
M src/mainboard/amd/mandolin/variants/mandolin/early_gpio.c
M src/soc/amd/picasso/include/soc/gpio.h
4 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved
  Frans Hendriks: Looks good to me, approved

diff --git a/src/mainboard/amd/mandolin/emmc_gpio.c b/src/mainboard/amd/mandolin/emmc_gpio.c
index 2ae72a6..a88a5c5 100644
--- a/src/mainboard/amd/mandolin/emmc_gpio.c
+++ b/src/mainboard/amd/mandolin/emmc_gpio.c
@@ -6,7 +6,7 @@
 /* eMMC controller driving either an SD card or eMMC device. */
 static const struct soc_amd_gpio emmc_gpios[] = {
    PAD_NF(GPIO_21,  EMMC_CMD,	PULL_UP),
-	PAD_NF(GPIO_22,  EMMC_PRW_CTRL,	PULL_UP),
+	PAD_NF(GPIO_22,  EMMC_PWR_CTRL,	PULL_UP),
    PAD_NF(GPIO_68,  EMMC_CD,	PULL_UP),
    PAD_NF(GPIO_70,  EMMC_CLK,	PULL_NONE),
    PAD_NF(GPIO_104, EMMC_DATA0,	PULL_UP),
diff --git a/src/mainboard/amd/mandolin/variants/cereme/early_gpio.c b/src/mainboard/amd/mandolin/variants/cereme/early_gpio.c
index b4ee5f4..800bd71 100644
--- a/src/mainboard/amd/mandolin/variants/cereme/early_gpio.c
+++ b/src/mainboard/amd/mandolin/variants/cereme/early_gpio.c
@@ -13,7 +13,7 @@
    /* not USB_OC2_L */
    PAD_GPI(GPIO_18, PULL_UP),
    /* SDIO eMMC power control */
-	PAD_NF(GPIO_22, EMMC_PRW_CTRL, PULL_NONE),
+	PAD_NF(GPIO_22, EMMC_PWR_CTRL, PULL_NONE),
    /* PCIe Reset 0 */
    PAD_NF(GPIO_26, PCIE_RST_L, PULL_NONE),
    /* PCIe Reset 1 */
diff --git a/src/mainboard/amd/mandolin/variants/mandolin/early_gpio.c b/src/mainboard/amd/mandolin/variants/mandolin/early_gpio.c
index 678de59..63e01ef 100644
--- a/src/mainboard/amd/mandolin/variants/mandolin/early_gpio.c
+++ b/src/mainboard/amd/mandolin/variants/mandolin/early_gpio.c
@@ -17,7 +17,7 @@
    /* not USB_OC2_L */
    PAD_GPI(GPIO_18, PULL_UP),
    /* SDIO eMMC power control */
-	PAD_NF(GPIO_22, EMMC_PRW_CTRL, PULL_NONE),
+	PAD_NF(GPIO_22, EMMC_PWR_CTRL, PULL_NONE),
    /* PCIe SSD power enable */
    PAD_GPO(GPIO_23, HIGH),
    /* PCIe Reset to DP0, DP1, J2105, TP, FP */
diff --git a/src/soc/amd/picasso/include/soc/gpio.h b/src/soc/amd/picasso/include/soc/gpio.h
index 8f33ca6..0f4507c 100644
--- a/src/soc/amd/picasso/include/soc/gpio.h
+++ b/src/soc/amd/picasso/include/soc/gpio.h
@@ -146,7 +146,7 @@
 #define GPIO_21_IOMUX_EMMC_CMD 1
 #define GPIO_21_IOMUX_GPIOxx 2
 #define GPIO_22_IOMUX_LPC_PME_L 0
-#define GPIO_22_IOMUX_EMMC_PRW_CTRL 1
+#define GPIO_22_IOMUX_EMMC_PWR_CTRL 1
 #define GPIO_22_IOMUX_GPIOxx 2
 #define GPIO_23_IOMUX_AC_PRES 0
 #define GPIO_23_IOMUX_SGPIO_LOAD 1