Attention is currently required from: Angel Pons, Eric Lai, John Su, John Zhao, Kapil Porwal, Matt DeVillier, Sean Rhodes, Subrata Banik.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72909?usp=email )
Change subject: soc/intel/common/tcss: Configure USB-C ports with attached devices
......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/72909/comment/b8c410b9_1fc8e05f :
PS5, Line 363: zd
%zd is consistent with the function above from which this one is adapted. […]
then please prepare CL changing `%zd` to %zu` and rebase this CL onto it.
https://review.coreboot.org/c/coreboot/+/72909/comment/5b9b2c42_c9c145c8 :
PS5, Line 459: if (CONFIG(EC_GOOGLE_CHROMEEC))
the guard needs to be devices which implement usbc_ops, otherwise compilation fails. […]
Maybe it would be better to add new Kconfig option like `ENABLE_TCSS_USB_DETECTION` and select it in board/model config instead like it is done with `ENABLE_TCSS_DISPLAY_DETECTION` (see src/mainboard/google/rex/Kconfig -> BOARD_BOOBLE_BASEBOARD_OVIS)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72909?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69522dbcc8cae6bbf41659ae653107d0e031c812
Gerrit-Change-Number: 72909
Gerrit-PatchSet: 6
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: CoolStar
coolstarorganization@gmail.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Jakub Czapiga
jacz@semihalf.com
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 04 Aug 2023 11:27:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment