Change in ...coreboot[master]: arch/x86/Kconfig: hide the "Bootblock behaviour" option on non-romcc
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33341
Change subject: arch/x86/Kconfig: hide the "Bootblock behaviour" option on non-romcc ......................................................................
arch/x86/Kconfig: hide the "Bootblock behaviour" option on non-romcc
Selecting which cbfs prefix to load is only implemented with the romcc bootblock.
Change-Id: I09523b94605f00ab15b5f0ea3986ac08e3a6afc6 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33341/1
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 36f2277..f8554385 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -239,9 +239,11 @@ Add a spin (JMP .) in assembly_entry.S during early romstage to wait for a JTAG debugger to break into the execution sequence.
+# Selecting a cbfs prefix from the bootblock is only implemented with romcc choice prompt "Bootblock behaviour" default BOOTBLOCK_SIMPLE + depends on !C_ENVIRONMENT_BOOTBLOCK
config BOOTBLOCK_SIMPLE bool "Always load fallback"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33341 )
Change subject: arch/x86/Kconfig: hide the "Bootblock behaviour" option on non-romcc ......................................................................
Patch Set 1: Code-Review+1
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33341 )
Change subject: arch/x86/Kconfig: hide the "Bootblock behaviour" option on non-romcc ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33341 )
Change subject: arch/x86/Kconfig: hide the "Bootblock behaviour" option on non-romcc ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33341 )
Change subject: arch/x86/Kconfig: hide the "Bootblock behaviour" option on non-romcc ......................................................................
arch/x86/Kconfig: hide the "Bootblock behaviour" option on non-romcc
Selecting which cbfs prefix to load is only implemented with the romcc bootblock.
Change-Id: I09523b94605f00ab15b5f0ea3986ac08e3a6afc6 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/33341 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/arch/x86/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Patrick Rudolph: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 5b1304f..06aaded 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -239,9 +239,11 @@ Add a spin (JMP .) in assembly_entry.S during early romstage to wait for a JTAG debugger to break into the execution sequence.
+# Selecting a cbfs prefix from the bootblock is only implemented with romcc choice prompt "Bootblock behaviour" default BOOTBLOCK_SIMPLE + depends on !C_ENVIRONMENT_BOOTBLOCK
config BOOTBLOCK_SIMPLE bool "Always load fallback"
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Nico Huber (Code Review)
-
Patrick Rudolph (Code Review)