Attention is currently required from: Ravi kumar, Martin Roth, Paul Menzel, Julius Werner, mturney mturney.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51758 )
Change subject: QC SOCs: update code moved to common/
......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51758/comment/c71f4904_ed35cc62
PS5, Line 7: QC SOCs: update code moved to common/
I will address
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/51758/comment/795d14a4_945b0219
PS7, Line 7: update code moved to common/
That sounds strange. Maybe: […]
Ack
Patchset:
PS7:
Looks good once you update the message
updated commit description with details
File src/soc/qualcomm/qcs405/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51758/comment/6f4cb095_b6c71f54
PS7, Line 12: all-$(CONFIG_DRIVERS_UART) += uart.c
I think that it's ok to include the Makefile cleanup code in this CL. […]
added detailed description in commit message
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51758
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48464567974a0729c1c6b6157bcce4fac39a8b38
Gerrit-Change-Number: 51758
Gerrit-PatchSet: 7
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 06 Apr 2021 05:25:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-MessageType: comment