Hello Akshu Agrawal,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44010
to review the following change.
Change subject: mb/google/zork: Pass oscout system clk to rt5682 ......................................................................
mb/google/zork: Pass oscout system clk to rt5682
mclk-name is set to 48Mhz oscclk1, oscout system clock is the linked to rt5682 mclk.
Signed-off-by: Akshu Agrawal akshu.agrawal@amd.com
BUG=b:158906189 TEST=rt5682 driver get the correct clk and tested audio playback
Change-Id: Ic565e8e0573e085e5759b2d3688cc0a4533b67fe --- M src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb 2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/44010/1
diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb index e2d9183..d155a6b 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb @@ -301,10 +301,13 @@ register "uid" = "1" register "desc" = ""Realtek RT5682"" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(62)" - register "property_count" = "1" + register "property_count" = "2" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" register "property_list[0].integer" = "1" + register "property_list[1].type" = "ACPI_DP_TYPE_STRING" + register "property_list[1].name" = ""realtek,mclk-name"" + register "property_list[1].string" = ""oscout1"" device i2c 1a on end end end diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb index bbef702..0831b7e 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb @@ -330,10 +330,13 @@ register "uid" = "1" register "desc" = ""Realtek RT5682"" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(62)" - register "property_count" = "1" + register "property_count" = "2" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" register "property_list[0].integer" = "1" + register "property_list[1].type" = "ACPI_DP_TYPE_STRING" + register "property_list[1].name" = ""realtek,mclk-name"" + register "property_list[1].string" = ""oscout1"" device i2c 1a on end end end
Akshu Agrawal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44010 )
Change subject: mb/google/zork: Pass oscout system clk to rt5682 ......................................................................
Patch Set 1:
kernel patch recv. the property https://patchwork.kernel.org/patch/11648137/
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44010 )
Change subject: mb/google/zork: Pass oscout system clk to rt5682 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44010/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44010/1//COMMIT_MSG@9 PS1, Line 9: mclk-name is set to 48Mhz oscclk1 Where is this set? I'm confused by the description of the patch. Could you pleas reword it to make things clearer?
https://review.coreboot.org/c/coreboot/+/44010/1//COMMIT_MSG@10 PS1, Line 10: the then? or remove the 'the?
Hello build bot (Jenkins), Furquan Shaikh, Akshu Agrawal, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44010
to look at the new patch set (#2).
Change subject: mb/google/zork: Pass oscout system clk to rt5682 ......................................................................
mb/google/zork: Pass oscout system clk to rt5682
In kernel clk for AMD SoCs we expose a generic clk by the name oscclk1. This oscclk1 is a fixed 48Mhz frequency clk in RV.
In Zork oscout system clock is linked to rt5682 mclk. Setting mclk-name to oscclk1 tells rt5682 driver its mclk is oscclk1.
Signed-off-by: Akshu Agrawal akshu.agrawal@amd.com
BUG=b:158906189 TEST=rt5682 driver get the correct clk and tested audio playback
Change-Id: Ic565e8e0573e085e5759b2d3688cc0a4533b67fe --- M src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb 2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/44010/2
Akshu Agrawal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44010 )
Change subject: mb/google/zork: Pass oscout system clk to rt5682 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44010/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44010/1//COMMIT_MSG@9 PS1, Line 9: mclk-name is set to 48Mhz oscclk1
Where is this set? I'm confused by the description of the patch. […]
Done, reworded the commit message explaining the clk structure.
https://review.coreboot.org/c/coreboot/+/44010/1//COMMIT_MSG@10 PS1, Line 10: the
then? or remove the 'the?
Done
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44010 )
Change subject: mb/google/zork: Pass oscout system clk to rt5682 ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44010 )
Change subject: mb/google/zork: Pass oscout system clk to rt5682 ......................................................................
mb/google/zork: Pass oscout system clk to rt5682
In kernel clk for AMD SoCs we expose a generic clk by the name oscclk1. This oscclk1 is a fixed 48Mhz frequency clk in RV.
In Zork oscout system clock is linked to rt5682 mclk. Setting mclk-name to oscclk1 tells rt5682 driver its mclk is oscclk1.
Signed-off-by: Akshu Agrawal akshu.agrawal@amd.com
BUG=b:158906189 TEST=rt5682 driver get the correct clk and tested audio playback
Change-Id: Ic565e8e0573e085e5759b2d3688cc0a4533b67fe Reviewed-on: https://review.coreboot.org/c/coreboot/+/44010 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb M src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb 2 files changed, 8 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb index aae84b7..9b40ca0 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb @@ -309,10 +309,13 @@ register "uid" = "1" register "desc" = ""Realtek RT5682"" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(62)" - register "property_count" = "1" + register "property_count" = "2" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" register "property_list[0].integer" = "1" + register "property_list[1].type" = "ACPI_DP_TYPE_STRING" + register "property_list[1].name" = ""realtek,mclk-name"" + register "property_list[1].string" = ""oscout1"" device i2c 1a on end end end diff --git a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb index 39a4827..1b43cc8 100644 --- a/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb +++ b/src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb @@ -334,10 +334,13 @@ register "uid" = "1" register "desc" = ""Realtek RT5682"" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(62)" - register "property_count" = "1" + register "property_count" = "2" register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" register "property_list[0].integer" = "1" + register "property_list[1].type" = "ACPI_DP_TYPE_STRING" + register "property_list[1].name" = ""realtek,mclk-name"" + register "property_list[1].string" = ""oscout1"" device i2c 1a on end end end
-
Aaron Durbin (Code Review) -
Akshu Agrawal (Code Review)