Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50477 )
Change subject: sb/intel/lynxpoint: Only generate SerialIO SSDT for PCH-LP ......................................................................
sb/intel/lynxpoint: Only generate SerialIO SSDT for PCH-LP
Lynxpoint PCH-H does not have SerialIO, so do not generate its SSDT.
Change-Id: Ie816ebd470df93a45826498bf21be59ff0a813bf Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/50477 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/southbridge/intel/lynxpoint/lpc.c 1 file changed, 8 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index b0ff545..3685a41 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -692,7 +692,6 @@ struct acpi_rsdp *rsdp) { unsigned long current; - acpi_header_t *ssdt;
current = start;
@@ -706,12 +705,14 @@
current = acpi_align_current(current);
- printk(BIOS_DEBUG, "ACPI: * SSDT2\n"); - ssdt = (acpi_header_t *)current; - acpi_create_serialio_ssdt(ssdt); - current += ssdt->length; - acpi_add_table(rsdp, ssdt); - current = acpi_align_current(current); + if (pch_is_lp()) { + printk(BIOS_DEBUG, "ACPI: * SSDT2\n"); + acpi_header_t *ssdt = (acpi_header_t *)current; + acpi_create_serialio_ssdt(ssdt); + current += ssdt->length; + acpi_add_table(rsdp, ssdt); + current = acpi_align_current(current); + }
printk(BIOS_DEBUG, "current = %lx\n", current); return current;