Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40914 )
Change subject: mb/purism/librem_bdw: cleanup 15v2 devicetree ......................................................................
mb/purism/librem_bdw: cleanup 15v2 devicetree
The Librem 15v2 only uses SATA ports 0/1, so the DTLE settings for ports 2/3 have no consequence. Drop them to make overridetree conversion cleaner.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: I4145feecb389be90f317249426e58752c03aef76 --- M src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40914/1
diff --git a/src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb b/src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb index 32c3ed1..cbd59be 100644 --- a/src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb +++ b/src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb @@ -28,8 +28,6 @@ # Port tuning for link stability register "sata_port0_gen3_dtle" = "7" register "sata_port1_gen3_dtle" = "9" - register "sata_port2_gen3_dtle" = "9" - register "sata_port3_gen3_dtle" = "7"
device cpu_cluster 0 on device lapic 0 on end
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40914 )
Change subject: mb/purism/librem_bdw: cleanup 15v2 devicetree ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40914/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40914/1//COMMIT_MSG@7 PS1, Line 7: cleanup Clean up
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40914
to look at the new patch set (#2).
Change subject: mb/purism/librem_bdw: Clean up 15v2 devicetree ......................................................................
mb/purism/librem_bdw: Clean up 15v2 devicetree
The Librem 15v2 only uses SATA ports 0/1, so the DTLE settings for ports 2/3 have no consequence. Drop them to make overridetree conversion cleaner.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: I4145feecb389be90f317249426e58752c03aef76 --- M src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40914/2
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40914 )
Change subject: mb/purism/librem_bdw: Clean up 15v2 devicetree ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40914/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40914/1//COMMIT_MSG@7 PS1, Line 7: cleanup
Clean up
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40914 )
Change subject: mb/purism/librem_bdw: Clean up 15v2 devicetree ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40914 )
Change subject: mb/purism/librem_bdw: Clean up 15v2 devicetree ......................................................................
mb/purism/librem_bdw: Clean up 15v2 devicetree
The Librem 15v2 only uses SATA ports 0/1, so the DTLE settings for ports 2/3 have no consequence. Drop them to make overridetree conversion cleaner.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: I4145feecb389be90f317249426e58752c03aef76 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40914 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb b/src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb index 32c3ed1..cbd59be 100644 --- a/src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb +++ b/src/mainboard/purism/librem_bdw/variants/librem15v2/devicetree.cb @@ -28,8 +28,6 @@ # Port tuning for link stability register "sata_port0_gen3_dtle" = "7" register "sata_port1_gen3_dtle" = "9" - register "sata_port2_gen3_dtle" = "9" - register "sata_port3_gen3_dtle" = "7"
device cpu_cluster 0 on device lapic 0 on end
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)