Change in gerrit-avatars[master]: My avatar.

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Bao Zheng (Code Review)

11 Jun 2020 11 Jun '20

5:21 a.m.

Hello Zheng Bao,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/gerrit-avatars/+/42273

to review the following change.

Change subject: My avatar. ......................................................................

My avatar.

Change-Id: If3b7be405d6f8e49177ece19ef8641b8dffd8604 Signed-off-by: Zheng Bao zheng.bao@amd.com --- M 1000034.jpg 1 file changed, 0 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/gerrit-avatars refs/changes/73/42273/1

diff --git a/1000034.jpg b/1000034.jpg index 1c7d0dd..a9662ce 100644 --- a/1000034.jpg +++ b/1000034.jpg Binary files differ

Attachments:

attachment.htm (text/html — 1.9 KB)

Show replies by date

Bao Zheng (Code Review)

11 Jun 11 Jun

5:38 a.m.

Hello build bot (Jenkins), Zheng Bao, Zheng Bao,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/gerrit-avatars/+/42273

to look at the new patch set (#2).

Change subject: My avatar. ......................................................................

My avatar.

Change-Id: If3b7be405d6f8e49177ece19ef8641b8dffd8604 Signed-off-by: Zheng Bao zheng.bao@amd.com Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M 1000034.jpg 1 file changed, 0 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/gerrit-avatars refs/changes/73/42273/2

Angel Pons (Code Review)

2:04 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/gerrit-avatars/+/42273 )

Change subject: My avatar. ......................................................................

Patch Set 2: Code-Review+1

(3 comments)

https://review.coreboot.org/c/gerrit-avatars/+/42273/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/gerrit-avatars/+/42273/2//COMMIT_MSG@7 PS2, Line 7: My avatar. nit: commit summaries have a verb in imperative mood, and do not end with a period:

Update my avatar

https://review.coreboot.org/c/gerrit-avatars/+/42273/2//COMMIT_MSG@10 PS2, Line 10: Signed-off-by: Zheng Bao zheng.bao@amd.com There are two `Signed-off-by` lines. Since both are you, maybe keep only one?

https://review.coreboot.org/c/gerrit-avatars/+/42273/2/1000034.jpg File 1000034.jpg:

PS2: Jenkins says: image not square

-- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/42273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: If3b7be405d6f8e49177ece19ef8641b8dffd8604 Gerrit-Change-Number: 42273 Gerrit-PatchSet: 2 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: Zheng Bao zheng.bao@amd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 11 Jun 2020 14:04:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Bao Zheng (Code Review)

3 p.m.

New subject: Change in gerrit-avatars[master]: Update my avatar

Hello build bot (Jenkins), Zheng Bao, Angel Pons, Zheng Bao,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/gerrit-avatars/+/42273

to look at the new patch set (#3).

Change subject: Update my avatar ......................................................................

Update my avatar

Change-Id: If3b7be405d6f8e49177ece19ef8641b8dffd8604 Signed-off-by: Zheng Bao zheng.bao@amd.com --- M 1000034.jpg 1 file changed, 0 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/gerrit-avatars refs/changes/73/42273/3

-- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/42273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: If3b7be405d6f8e49177ece19ef8641b8dffd8604 Gerrit-Change-Number: 42273 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: Zheng Bao zheng.bao@amd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Bao Zheng (Code Review)

3:06 p.m.

New subject: Change in gerrit-avatars[master]: Update my avatar

Bao Zheng has submitted this change. ( https://review.coreboot.org/c/gerrit-avatars/+/42273 )

Change subject: Update my avatar ......................................................................

Update my avatar

Change-Id: If3b7be405d6f8e49177ece19ef8641b8dffd8604 Signed-off-by: Zheng Bao zheng.bao@amd.com --- M 1000034.jpg 1 file changed, 0 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified; Looks good to me, approved

diff --git a/1000034.jpg b/1000034.jpg index 1c7d0dd..991b7f2 100644 --- a/1000034.jpg +++ b/1000034.jpg Binary files differ

-- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/42273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: If3b7be405d6f8e49177ece19ef8641b8dffd8604 Gerrit-Change-Number: 42273 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: Zheng Bao zheng.bao@amd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

Angel Pons (Code Review)

4:56 p.m.

New subject: Change in gerrit-avatars[master]: Update my avatar

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/gerrit-avatars/+/42273 )

Change subject: Update my avatar ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/42273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: If3b7be405d6f8e49177ece19ef8641b8dffd8604 Gerrit-Change-Number: 42273 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: Zheng Bao zheng.bao@amd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 11 Jun 2020 16:56:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Bao Zheng (Code Review)

22 Oct 22 Oct

1:22 a.m.

New subject: Change in gerrit-avatars[master]: Update my avatar

Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/gerrit-avatars/+/42273 )

Change subject: Update my avatar ......................................................................

Patch Set 3:

(2 comments)

Commit Message:

https://review.coreboot.org/c/gerrit-avatars/+/42273/comment/aa6f333d_eb9cc0... PS2, Line 10: Signed-off-by: Zheng Bao zheng.bao@amd.com

...

There are two `Signed-off-by` lines. […]

Done

File 1000034.jpg:

PS2:

...

Jenkins says: image not square

Done

-- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/42273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: If3b7be405d6f8e49177ece19ef8641b8dffd8604 Gerrit-Change-Number: 42273 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Bao Zheng fishbaozi@gmail.com Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: Zheng Bao zheng.bao@amd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 22 Oct 2021 01:22:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

1134

days inactive

1632

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
Bao Zheng (Code Review)