Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Patrick Rudolph.
Felix Held has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86620?usp=email )
Change subject: soc/amd/common/block: Cache ROM3
......................................................................
Patch Set 11:
(2 comments)
File src/soc/amd/common/block/cpu/noncar/early_cache.c:
https://review.coreboot.org/c/coreboot/+/86620/comment/f749cc76_94aa490b?usp... :
PS11, Line 69: SOC_AMD_COMMON_BLOCK_LPC_USE_ROM3
should probably be SOC_AMD_COMMON_BLOCK_SPI_MMAP_USE_ROM3
File src/soc/amd/common/block/cpu/noncar/mpinit.c:
https://review.coreboot.org/c/coreboot/+/86620/comment/ef94606d_a051c579?usp... :
PS11, Line 24: SOC_AMD_COMMON_BLOCK_LPC_USE_ROM3
same here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86620?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2df51ee3f492e5a80f5ee2676196830045dcdeb3
Gerrit-Change-Number: 86620
Gerrit-PatchSet: 11
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Mon, 14 Apr 2025 13:10:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No