build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25810 )
Change subject: [WIP]soc/intel/common: Add common code to report platform information ......................................................................
Patch Set 4:
(42 comments)
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... File src/soc/intel/common/basecode/bootblock/report_platform.c:
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 31: __attribute__((weak)) const struct cpu_info* soc_get_cpu_id_table(void) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 37: __attribute__((weak)) const struct mch_info* soc_get_mch_id_table(void) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 43: __attribute__((weak)) const struct pch_info* soc_get_pch_id_table(void) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 49: __attribute__((weak)) const struct igd_info* soc_get_igd_id_table(void) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 65: static void report_cpu_info(const struct cpu_info* cpu_info_table) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 81: int j=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 90: p[12]=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 104: while (cpu_info_table[t].name != NULL ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 124: static void report_mch_info(const struct mch_info* mch_info_table) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 132: while (mch_info_table[i].name != NULL ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 144: static void report_pch_info(const struct pch_info* pch_info_table) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 151: while (pch_info_table[i].name != NULL ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 162: static void report_igd_info(const struct igd_info* igd_info_table) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 169: while (igd_info_table[i].name != NULL ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 182: const struct cpu_info* cpu_info_table = soc_get_cpu_id_table(); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 183: const struct mch_info* mch_info_table = soc_get_mch_id_table(); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 184: const struct pch_info* pch_info_table = soc_get_pch_id_table(); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/bootbl... PS4, Line 185: const struct igd_info* igd_info_table = soc_get_igd_id_table(); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... File src/soc/intel/common/basecode/include/intelbasecode/report_platform.h:
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 19: struct cpu_info{ missing space after struct definition
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 20: u32 cpuid; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 20: u32 cpuid; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 21: const char *name; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 21: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 24: struct mch_info{ missing space after struct definition
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 25: u16 mchid; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 25: u16 mchid; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 26: const char *name; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 26: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 29: struct pch_info{ missing space after struct definition
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 30: u16 lpcid; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 30: u16 lpcid; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 31: const char *name; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 31: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 34: struct igd_info{ missing space after struct definition
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 35: u16 igdid; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 35: u16 igdid; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 36: const char *name; code indent should use tabs where possible
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 36: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 40: const struct cpu_info* soc_get_cpu_id_table(void); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 43: const struct mch_info* soc_get_mch_id_table(void); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 46: const struct pch_info* soc_get_pch_id_table(void); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/25810/4/src/soc/intel/common/basecode/includ... PS4, Line 49: const struct igd_info* soc_get_igd_id_table(void); "foo* bar" should be "foo *bar"