Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Subrata Banik, Tarun.
Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Subrata Banik, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81333?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Code-Review+1 by Kyoung Il Kim, Verified+1 by build bot (Jenkins)
Change subject: mb/google/rex: Add Intel Touch for controller 1 for Rex ......................................................................
mb/google/rex: Add Intel Touch for controller 1 for Rex
GPIO pad configuration for THC1 according to CBI fw_config. ACPI entries in SSDT for ELAN according to CBI fw_config.
THC0 must be enabled when THC1 is enabled. Major rework is required for Rex P1 and P2. minor Rework is needed for EVT. Rex with THC rework won't be able to support UWB and FPCMU. The touch device must be converted to SPI interface. When THC is enabled and the THC rework is in place, the UWB and FPMCU are not supported and need to be disable from the CBI. THC0 will also be provided with ACPI entries when THC1 is enabled. THC1 GPIO pins will be configured for THC according to the CBI TOUCHSCREEN fw_config field. The resistor on the THC-SPI MISO pin should be 100 Ohm.
BUG=b:307775082
TEST=set CBI TOUCHSREEN fw_config to TOUCHSCREEN_THC, FP fw_config to FP_ABSENT, and UWB fw_config to UWB_ABSENT. boot Rex to OS and run lspci to check THC device and check that THC device driver initialization successfully. /sys/class/hidraw/hidraw0/device/input/ should have several inputs enumerated.
Signed-off-by: Cliff Huang cliff.huang@intel.com Change-Id: Id89b5b46d67b90491410d3d08c1a3ae9549b4da5 --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/rex0/fw_config.c M src/mainboard/google/rex/variants/rex0/overridetree.cb 3 files changed, 163 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/81333/4