Change in coreboot[master]: soc/intel/common: add Kconfig to enable/disable the ACPI PM timer
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45952 )
Change subject: soc/intel/common: add Kconfig to enable/disable the ACPI PM timer ......................................................................
Patch Set 19: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45952/19//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45952/19//COMMIT_MSG@25 PS19, Line 25: unknown if that is desireable on that platform. Any clue if APL has that timer?
https://review.coreboot.org/c/coreboot/+/45952/19/src/soc/intel/common/block... File src/soc/intel/common/block/smm/Kconfig:
https://review.coreboot.org/c/coreboot/+/45952/19/src/soc/intel/common/block... PS19, Line 20: depends on USE_PM_ACPI_TIMER Wouldn't a select be better? It's easy to miss an option if it's not visible.
-
Nico Huber (Code Review)