Attention is currently required from: Raul Rangel, Julius Werner. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63791 )
Change subject: include/device/i2c_simple: add i2c_read_eeprom_bytes function ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
No objections but I feel that the name `eeprom` is a bit overly specific here. […]
yes, the name is probably overly specific, but i didn't have a much better name. most i2c devices will only use a 1 byte index/offset and the only devices that use 2 byte index/offset that i could think of were the eeproms, but there are likely other i2c devices that use 2 bytes of index/offset. from the name i2c_read16_bytes i'd expect that it does 16 bit reads, so at least for me that makes things a bit more confusing.
what do you think about i2c_1ba_read and i2c_2ba_read as function names? maybe with some comment that has the acronym expanded to 1/2 byte address