Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32366
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
soc/intel/common/acpi: Add dynamic method around sleep
Declare plaform level hook method before and after system sleep for possible power management related usage.
BUG=N/A TEST=pass with make what-jenkins-does
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie63711748b6dbb99d34910824f2059464543e162 --- M src/soc/intel/common/acpi/platform.asl 1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/32366/1
diff --git a/src/soc/intel/common/acpi/platform.asl b/src/soc/intel/common/acpi/platform.asl index bdc0d5c..7ca19c1 100644 --- a/src/soc/intel/common/acpi/platform.asl +++ b/src/soc/intel/common/acpi/platform.asl @@ -17,6 +17,9 @@
#include <include/console/post_codes.h>
+External(_SB.PCI0.MPTS, MethodObj) +External(_SB.PCI0.MWAK, MethodObj) + /* Port 80 POST */
OperationRegion (POST, SystemIO, CONFIG_POST_IO_PORT, 1) @@ -38,6 +41,10 @@ /* Call EC _PTS handler */ _SB.PCI0.LPCB.EC0.PTS (Arg0) #endif + If(CondRefOf (_SB.PCI0.MPTS)) + { + _SB.PCI0.MPTS (Arg0) + } }
/* The _WAK method is called on system wakeup */ @@ -50,6 +57,10 @@ /* Call EC _WAK handler */ _SB.PCI0.LPCB.EC0.WAK (Arg0) #endif + If(CondRefOf (_SB.PCI0.MWAK)) + { + _SB.PCI0.MWAK (Arg0) + }
Return (Package(){0,0}) }
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32366
to look at the new patch set (#2).
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
soc/intel/common/acpi: Add dynamic method around sleep
Declare plaform level hook method before and after system sleep for possible power management related usage.
BUG=N/A TEST=pass with make what-jenkins-does
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie63711748b6dbb99d34910824f2059464543e162 --- M src/soc/intel/common/acpi/platform.asl 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/32366/2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32366 )
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... File src/soc/intel/common/acpi/platform.asl:
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... PS2, Line 41: /* Call EC _PTS handler */ : _SB.PCI0.LPCB.EC0.PTS (Arg0) I wonder if we should move this into the new MPTS/MWAK too, since that is where the EC is hooked up.
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... PS2, Line 44: ( Please add a space between If and ( to keep the style consistent
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32366 )
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... File src/soc/intel/common/acpi/platform.asl:
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... PS2, Line 41: /* Call EC _PTS handler */ : _SB.PCI0.LPCB.EC0.PTS (Arg0)
I wonder if we should move this into the new MPTS/MWAK too, since that is where the EC is hooked up.
Yes I will have a follow up patch to move it same way.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32366 )
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... File src/soc/intel/common/acpi/platform.asl:
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... PS2, Line 44: (
Please add a space between If and ( to keep the style consistent
Done
Hello Patrick Rudolph, Duncan Laurie, Bora Guvendik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32366
to look at the new patch set (#3).
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
soc/intel/common/acpi: Add dynamic method around sleep
Declare plaform level hook method before and after system sleep for possible power management related usage.
BUG=N/A TEST=pass with make what-jenkins-does
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie63711748b6dbb99d34910824f2059464543e162 --- M src/soc/intel/common/acpi/platform.asl 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/32366/3
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32366 )
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... File src/soc/intel/common/acpi/platform.asl:
https://review.coreboot.org/#/c/32366/2/src/soc/intel/common/acpi/platform.a... PS2, Line 41: /* Call EC _PTS handler */ : _SB.PCI0.LPCB.EC0.PTS (Arg0)
I wonder if we should move this into the new MPTS/MWAK too, since that is where the EC is hooked up.
https://review.coreboot.org/c/coreboot/+/32371 , or move into MPTS/MWAK is also fine.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32366 )
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32366/4/src/soc/intel/common/acpi/platform.a... File src/soc/intel/common/acpi/platform.asl:
https://review.coreboot.org/#/c/32366/4/src/soc/intel/common/acpi/platform.a... PS4, Line 44: PCI0 The PCI0 part seems a bit out of place, could these be just _SB.M{PTS,WAK}?
Hello Patrick Rudolph, Duncan Laurie, Bora Guvendik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32366
to look at the new patch set (#5).
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
soc/intel/common/acpi: Add dynamic method around sleep
Declare plaform level hook method before and after system sleep for possible power management related usage.
BUG=N/A TEST=pass with make what-jenkins-does
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie63711748b6dbb99d34910824f2059464543e162 --- M src/soc/intel/common/acpi/platform.asl 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/32366/5
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32366 )
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32366/4/src/soc/intel/common/acpi/platform.a... File src/soc/intel/common/acpi/platform.asl:
https://review.coreboot.org/#/c/32366/4/src/soc/intel/common/acpi/platform.a... PS4, Line 44: PCI0
The PCI0 part seems a bit out of place, could these be just _SB. […]
Done
Hello Patrick Rudolph, Duncan Laurie, Bora Guvendik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32366
to look at the new patch set (#6).
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
soc/intel/common/acpi: Add dynamic method around sleep
Declare plaform level hook method before and after system sleep for possible power management related usage.
BUG=N/A TEST=pass with make what-jenkins-does
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie63711748b6dbb99d34910824f2059464543e162 --- M src/soc/intel/common/acpi/platform.asl 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/32366/6
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32366 )
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32366 )
Change subject: soc/intel/common/acpi: Add dynamic method around sleep ......................................................................
soc/intel/common/acpi: Add dynamic method around sleep
Declare plaform level hook method before and after system sleep for possible power management related usage.
BUG=N/A TEST=pass with make what-jenkins-does
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: Ie63711748b6dbb99d34910824f2059464543e162 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32366 Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/acpi/platform.asl 1 file changed, 12 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/soc/intel/common/acpi/platform.asl b/src/soc/intel/common/acpi/platform.asl index bdc0d5c..8b85d44 100644 --- a/src/soc/intel/common/acpi/platform.asl +++ b/src/soc/intel/common/acpi/platform.asl @@ -17,6 +17,9 @@
#include <include/console/post_codes.h>
+External(_SB.MPTS, MethodObj) +External(_SB.MWAK, MethodObj) + /* Port 80 POST */
OperationRegion (POST, SystemIO, CONFIG_POST_IO_PORT, 1) @@ -38,6 +41,10 @@ /* Call EC _PTS handler */ _SB.PCI0.LPCB.EC0.PTS (Arg0) #endif + If (CondRefOf (_SB.MPTS)) + { + _SB.MPTS (Arg0) + } }
/* The _WAK method is called on system wakeup */ @@ -46,6 +53,11 @@ { Store (POST_OS_ENTER_WAKE, DBG0)
+ If (CondRefOf (_SB.MWAK)) + { + _SB.MWAK (Arg0) + } + #if CONFIG(SOC_INTEL_COMMON_ACPI_EC_PTS_WAK) /* Call EC _WAK handler */ _SB.PCI0.LPCB.EC0.WAK (Arg0)