Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81201?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: amdfwtool: Compact the parameter transfering ......................................................................
amdfwtool: Compact the parameter transfering
Remove redundant parameter "debug" from open_process_config().
Change-Id: Ib91a505838d7be4980d6b4f1e95fb8601fbbfd16 Signed-off-by: Zheng Bao fishbaozi@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/81201 Reviewed-by: Fred Reitberger reitbergerfred@gmail.com Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/amdfwtool/amdfwtool.c 1 file changed, 4 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Fred Reitberger: Looks good to me, approved Felix Held: Looks good to me, approved
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 35d6cdf..ef97010 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1469,7 +1469,7 @@ return 0; }
-void open_process_config(char *config, amd_cb_config *cb_config, int debug) +void open_process_config(char *config, amd_cb_config *cb_config) { FILE *config_handle;
@@ -1490,7 +1490,7 @@ }
/* For debug. */ - if (debug) { + if (cb_config->debug) { dump_psp_firmwares(amd_psp_fw_table); dump_bdt_firmwares(amd_bios_table); } @@ -1539,7 +1539,7 @@ memcpy(ctx.amd_bios_table_clean, amd_bios_table, sizeof(amd_bios_table)); }
- open_process_config(cb_config.config, &cb_config, cb_config.debug); + open_process_config(cb_config.config, &cb_config);
ctx.rom = malloc(ctx.rom_size); if (!ctx.rom) { @@ -1625,8 +1625,7 @@ memcpy(amd_bios_table, ctx.amd_bios_table_clean, sizeof(amd_bios_table)); assert_fw_entry(combo_index, MAX_COMBO_ENTRIES, &ctx); - open_process_config(cb_config.combo_config[combo_index], &cb_config, - cb_config.debug); + open_process_config(cb_config.combo_config[combo_index], &cb_config);
/* In most cases, the address modes are same. */ if (cb_config.need_ish)