HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37377 )
Change subject: vendorcode/cavium/bdk/libbdk-hal: Add missing <stdlib.h> ......................................................................
vendorcode/cavium/bdk/libbdk-hal: Add missing <stdlib.h>
Change-Id: Id52603c525cce1bead423d188e23f6efd50511a9 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/37377/1
diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c index e078e74..cc6a5dd 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c @@ -12,6 +12,7 @@
#include <bdk.h> #include <libbdk-hal/bdk-config.h> +#include <stdlib.h> #include <string.h> #include <assert.h> #include <lame_string.h>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37377 )
Change subject: vendorcode/cavium/bdk/libbdk-hal: Add missing <stdlib.h> ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37377/1/src/vendorcode/cavium/bdk/l... File src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c:
https://review.coreboot.org/c/coreboot/+/37377/1/src/vendorcode/cavium/bdk/l... PS1, Line 32: malloc( needs #include <stdlib.h>
Hello Paul Menzel, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37377
to look at the new patch set (#2).
Change subject: vendorcode/cavium/bdk/libbdk-hal/bdk-config.c : Add missing <stdlib.h> ......................................................................
vendorcode/cavium/bdk/libbdk-hal/bdk-config.c : Add missing <stdlib.h>
Change-Id: Id52603c525cce1bead423d188e23f6efd50511a9 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/37377/2
Hello Paul Menzel, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37377
to look at the new patch set (#3).
Change subject: vendorcode/cavium/bdk/libbdk-hal/bdk-config.c: Add missing <stdlib.h> ......................................................................
vendorcode/cavium/bdk/libbdk-hal/bdk-config.c: Add missing <stdlib.h>
Change-Id: Id52603c525cce1bead423d188e23f6efd50511a9 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/37377/3
Hello Paul Menzel, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37377
to look at the new patch set (#4).
Change subject: vendorcode/cavium/bdk/libbdk-hal: Add missing <stdlib.h> ......................................................................
vendorcode/cavium/bdk/libbdk-hal: Add missing <stdlib.h>
Change-Id: Id52603c525cce1bead423d188e23f6efd50511a9 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/37377/4
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37377 )
Change subject: vendorcode/cavium/bdk/libbdk-hal: Add missing <stdlib.h> ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37377/8/src/vendorcode/cavium/bdk/l... File src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c:
https://review.coreboot.org/c/coreboot/+/37377/8/src/vendorcode/cavium/bdk/l... PS8, Line 32: malloc stdlib.h
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37377 )
Change subject: vendorcode/cavium/bdk/libbdk-hal: Add missing <stdlib.h> ......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37377/8/src/vendorcode/cavium/bdk/l... File src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c:
https://review.coreboot.org/c/coreboot/+/37377/8/src/vendorcode/cavium/bdk/l... PS8, Line 32: malloc
stdlib. […]
Ack
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37377 )
Change subject: vendorcode/cavium/bdk/libbdk-hal: Add missing <stdlib.h> ......................................................................
vendorcode/cavium/bdk/libbdk-hal: Add missing <stdlib.h>
Change-Id: Id52603c525cce1bead423d188e23f6efd50511a9 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37377 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c index e078e74..cc6a5dd 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c @@ -12,6 +12,7 @@
#include <bdk.h> #include <libbdk-hal/bdk-config.h> +#include <stdlib.h> #include <string.h> #include <assert.h> #include <lame_string.h>