Change in coreboot[master]: trival: Fix typo of Kconfig setting

[Bao Zheng (Code Review)]

Hello Zheng Bao,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/45285

to review the following change.

Change subject: trival: Fix typo of Kconfig setting
......................................................................

trival: Fix typo of Kconfig setting

Change-Id: I5c89975cc317cb93e79509e885010d14a79dd7e1
Signed-off-by: Zheng Bao 
---
M src/soc/amd/picasso/Kconfig
M src/soc/amd/picasso/Makefile.inc
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45285/1

diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index 526900a..0e2db5f 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -429,7 +429,7 @@
    string
    default "3rdparty/amd_blobs/picasso/PSP/AmdPubKeyRV.bin"

-config USE_PSPSCUREOS
+config USE_PSPSECUREOS
    bool
    default y
    help
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc
index bbb064f..8eda2d8 100644
--- a/src/soc/amd/picasso/Makefile.inc
+++ b/src/soc/amd/picasso/Makefile.inc
@@ -147,7 +147,7 @@
 PSP_TOKEN_UNLOCK="--token-unlock"
 endif

-ifeq ($(CONFIG_USE_PSPSCUREOS),y)
+ifeq ($(CONFIG_USE_PSPSECUREOS),y)
 # types = 0x2
 PSPSCUREOS_FILE=$(FIRMWARE_LOCATE)/psp_os_combined_prod_RV.sbin
 endif

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: trival: Fix typo of Kconfig setting
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: trival: Fix typo of Kconfig setting
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45285/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45285/1//COMMIT_MSG@7 
PS1, Line 7: trival: Fix typo of Kconfig setting
Please use a common prefix: soc/amd/picasso.

The word *trivial* does not give any benefit to the commit message.

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: trival: Fix typo of Kconfig setting
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil... 
File src/soc/amd/picasso/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil... 
PS1, Line 152: PSPSCUREOS
Might as well fix the others with the same misspelling.  Also in
src/soc/amd/stoneyridge/Makefile.inc
src/southbridge/amd/pi/hudson/Makefile.inc

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: trival: Fix typo of Kconfig setting
......................................................................

Patch Set 1: -Code-Review

(1 comment)

https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil... 
File src/soc/amd/picasso/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil... 
PS1, Line 152: PSPSCUREOS
> Might as well fix the others with the same misspelling.  Also in […]

good catch

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Bao Zheng (Code Review)]

Hello build bot (Jenkins), Martin Roth, Patrick Georgi, Zheng Bao, HAOUAS Elyes,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45285

to look at the new patch set (#2).

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

soc/amd/picasso: Fix typo of Kconfig setting

USE_PSPSCUREOS -> USE_PSPSECUREOS.

Change-Id: I5c89975cc317cb93e79509e885010d14a79dd7e1
Signed-off-by: Zheng Bao 
---
M src/soc/amd/picasso/Kconfig
M src/soc/amd/picasso/Makefile.inc
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45285/2

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Bao Zheng (Code Review)]

Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45285/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45285/1//COMMIT_MSG@7 
PS1, Line 7: trival: Fix typo of Kconfig setting
> Please use a common prefix: soc/amd/picasso. […]

Changed.

https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil... 
File src/soc/amd/picasso/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil... 
PS1, Line 152: PSPSCUREOS
> good catch

This line will be removed at following patches in this stack.

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Bao Zheng (Code Review)]

Bao Zheng has removed Paul Menzel from this change.  ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Removed reviewer Paul Menzel.

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Jason Glenesk (Code Review)]

Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 2:

please run this cmd: git grep -r PSPSCUREOS

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45285/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45285/3//COMMIT_MSG@9 
PS3, Line 9: PSPSCUREOS
Please fix all "PSPSCUREOS" not only "USE_PSPSCUREOS".

this cmd may help:
find  -type f -name "Makefile.inc" -print0 | xargs -0 sed -i  's/PSPSCUREOS/PSPSECUREOS/g' && git commit -a -s -n --amend

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Bao Zheng (Code Review)]

Hello build bot (Jenkins), Jason Glenesk, Martin Roth, Patrick Georgi, Marshall Dawson, Dave Frodin, Zheng Bao, Matt Papageorge, HAOUAS Elyes, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45285

to look at the new patch set (#4).

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

soc/amd/picasso: Fix typo of Kconfig setting

USE_PSPSCUREOS -> USE_PSPSECUREOS.

Change-Id: I5c89975cc317cb93e79509e885010d14a79dd7e1
Signed-off-by: Zheng Bao 
---
M src/soc/amd/picasso/Kconfig
M src/soc/amd/picasso/Makefile.inc
M src/soc/amd/stoneyridge/Makefile.inc
M src/southbridge/amd/pi/hudson/Makefile.inc
4 files changed, 18 insertions(+), 18 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/45285/4

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil... 
File src/soc/amd/picasso/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil... 
PS1, Line 152: PSPSCUREOS
> This line will be removed at following patches in this stack.

Done

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45285/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45285/4//COMMIT_MSG@7 
PS4, Line 7: Fix typo of Kconfig setting
           : 
           : USE_PSPSCUREOS -> USE_PSPSECUREOS.
please update
Thank you.

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45285/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45285/3//COMMIT_MSG@9 
PS3, Line 9: PSPSCUREOS
> Please fix all "PSPSCUREOS" not only "USE_PSPSCUREOS". […]

Done

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Bao Zheng (Code Review)]

Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45285/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45285/3//COMMIT_MSG@9 
PS3, Line 9: PSPSCUREOS
> Done

Done.

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Bao Zheng (Code Review)]

Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 4:

(1 comment)

All typos have been changed.

https://review.coreboot.org/c/coreboot/+/45285/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45285/4//COMMIT_MSG@7 
PS4, Line 7: Fix typo of Kconfig setting
           : 
           : USE_PSPSCUREOS -> USE_PSPSECUREOS.
> please update […]

Done

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Bao Zheng (Code Review)]

Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil... 
File src/soc/amd/picasso/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45285/1/src/soc/amd/picasso/Makefil... 
PS1, Line 152: PSPSCUREOS
> Done

All have been changed anyway.

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Bao Zheng (Code Review)]

Bao Zheng has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

soc/amd/picasso: Fix typo of Kconfig setting

USE_PSPSCUREOS -> USE_PSPSECUREOS.

Change-Id: I5c89975cc317cb93e79509e885010d14a79dd7e1
Signed-off-by: Zheng Bao 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45285
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Held 
---
M src/soc/amd/picasso/Kconfig
M src/soc/amd/picasso/Makefile.inc
M src/soc/amd/stoneyridge/Makefile.inc
M src/southbridge/amd/pi/hudson/Makefile.inc
4 files changed, 18 insertions(+), 18 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved

diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index 3b12089..3d9b08d 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -443,7 +443,7 @@
    string
    default "3rdparty/amd_blobs/picasso/PSP/AmdPubKeyRV.bin"

-config USE_PSPSCUREOS
+config USE_PSPSECUREOS
    bool
    default y
    help
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc
index eb2be50..a9b1fe7 100644
--- a/src/soc/amd/picasso/Makefile.inc
+++ b/src/soc/amd/picasso/Makefile.inc
@@ -148,9 +148,9 @@
 PSP_TOKEN_UNLOCK="--token-unlock"
 endif

-ifeq ($(CONFIG_USE_PSPSCUREOS),y)
+ifeq ($(CONFIG_USE_PSPSECUREOS),y)
 # types = 0x2
-PSPSCUREOS_FILE=$(FIRMWARE_LOCATE)/psp_os_combined_prod_RV.sbin
+PSPSECUREOS_FILE=$(FIRMWARE_LOCATE)/psp_os_combined_prod_RV.sbin
 endif

# type = 0x21
@@ -283,7 +283,7 @@
 OPT_PSP_SEC_DBG_KEY_FILE=$(call add_opt_prefix, $(PSP_SEC_DBG_KEY_FILE), --securedebug)
 OPT_TOKEN_UNLOCK=$(call add_opt_prefix, $(PSP_TOKEN_UNLOCK), "")
 OPT_PSP_SOFTFUSE=$(call add_opt_prefix, $(PSP_SOFTFUSE), --soft-fuse)
-OPT_PSPSCUREOS_FILE=$(call add_opt_prefix, $(PSPSCUREOS_FILE), --secureos)
+OPT_PSPSECUREOS_FILE=$(call add_opt_prefix, $(PSPSECUREOS_FILE), --secureos)
 OPT_SEC_DEBUG_FILE=$(call add_opt_prefix, $(PSP_SEC_DEBUG_FILE), --secdebug)
 OPT_IKEK_FILE=$(call add_opt_prefix, $(PSP_IKEK_FILE), --ikek)
 OPT_SECG1_FILE=$(call add_opt_prefix, $(PSP_SECG1_FILE), --subprog 1 --sec-gasket)
@@ -335,7 +335,7 @@
 endif

AMDFW_COMMON_ARGS=$(OPT_AMD_PUBKEY_FILE) \
-		$(OPT_PSPSCUREOS_FILE) \
+		$(OPT_PSPSECUREOS_FILE) \
    	$(OPT_PSP_SEC_DBG_KEY_FILE) \
    	$(OPT_SMUFW1_SUB2_FILE) \
    	$(OPT_SMUFW2_SUB2_FILE) \
@@ -385,7 +385,7 @@

$(obj)/amdfw.rom:	$(call strip_quotes, $(CONFIG_AMD_PUBKEY_FILE)) \
    		$(call strip_quotes, $(PSPBTLDR_FILE)) \
-			$(call strip_quotes, $(PSPSCUREOS_FILE)) \
+			$(call strip_quotes, $(PSPSECUREOS_FILE)) \
    		$(call strip_quotes, $(PSP_SEC_DBG_KEY_FILE)) \
    		$(call strip_quotes, $(PSP_BIOSBIN_FILE)) \
    		$(call strip_quotes, $(PSP_PMUI_FILE1)) \
diff --git a/src/soc/amd/stoneyridge/Makefile.inc b/src/soc/amd/stoneyridge/Makefile.inc
index 0d7b5d1..16597e1 100644
--- a/src/soc/amd/stoneyridge/Makefile.inc
+++ b/src/soc/amd/stoneyridge/Makefile.inc
@@ -148,7 +148,7 @@

ifeq ($(CONFIG_USE_PSPSECUREOS),y)
 ###2
-PSPSCUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs_prod_$(FIRMWARE_TYPE).csbin
+PSPSECUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs_prod_$(FIRMWARE_TYPE).csbin

###12
 PSPTRUSTLETS_FILE=$(wildcard $(top)/$(FIRMWARE_LOCATE)/PspTrustlets*_prod_$(FIRMWARE_TYPE).cbin)
@@ -184,7 +184,7 @@
 OPT_PSPNVRAM_FILE=$(call add_opt_prefix, $(PSPNVRAM_FILE), --nvram)
 OPT_PSPSECUREDEBUG_FILE=$(call add_opt_prefix, $(PSPSECUREDEBUG_FILE), --securedebug)
 ifeq ($(CONFIG_USE_PSPSECUREOS),y)
-OPT_PSPSCUREOS_FILE=$(call add_opt_prefix, $(PSPSCUREOS_FILE), --secureos)
+OPT_PSPSECUREOS_FILE=$(call add_opt_prefix, $(PSPSECUREOS_FILE), --secureos)
 OPT_PSPTRUSTLETS_FILE=$(call add_opt_prefix, $(PSPTRUSTLETS_FILE), --trustlets)
 OPT_TRUSTLETKEY_FILE=$(call add_opt_prefix, $(TRUSTLETKEY_FILE), --trustletkey)
 endif
@@ -204,7 +204,7 @@
    		$(call strip_quotes, $(PUBSIGNEDKEY_FILE)) \
    		$(call strip_quotes, $(PSPBTLDR_FILE)) \
    		$(call strip_quotes, $(PSPRCVR_FILE)) \
-			$(call strip_quotes, $(PSPSCUREOS_FILE)) \
+			$(call strip_quotes, $(PSPSECUREOS_FILE)) \
    		$(call strip_quotes, $(PSPNVRAM_FILE)) \
    		$(call strip_quotes, $(SMUFWM_FILE)) \
    		$(call strip_quotes, $(SMUFWM_FN_FILE)) \
@@ -225,7 +225,7 @@
    	$(OPT_SMUFWM_FILE) \
    	$(OPT_PSPRCVR_FILE) \
    	$(OPT_PUBSIGNEDKEY_FILE) \
-		$(OPT_PSPSCUREOS_FILE) \
+		$(OPT_PSPSECUREOS_FILE) \
    	$(OPT_PSPNVRAM_FILE) \
    	$(OPT_PSPSECUREDEBUG_FILE) \
    	$(OPT_PSPTRUSTLETS_FILE) \
@@ -238,7 +238,7 @@
    	$(OPT_SMUFWM_FN_FILE) \
    	$(OPT_PSPRCVR_FILE) \
    	$(OPT_PUBSIGNEDKEY_FILE) \
-		$(OPT_PSPSCUREOS_FILE) \
+		$(OPT_PSPSECUREOS_FILE) \
    	$(OPT_PSPNVRAM_FILE) \
    	$(OPT_PSPSECUREDEBUG_FILE) \
    	$(OPT_PSPTRUSTLETS_FILE) \
diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc
index da861ee..09bf1d6 100644
--- a/src/southbridge/amd/pi/hudson/Makefile.inc
+++ b/src/southbridge/amd/pi/hudson/Makefile.inc
@@ -83,7 +83,7 @@

PSPBTLDR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspBootLoader.Bypass.sbin
 #PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecovery.sbin
-#PSPSCUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs.sbin
+#PSPSECUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs.sbin
 #PSPTRUSTLETS_FILE=$(top)/$(FIRMWARE_LOCATE)/trustlets.bin
 #TRUSTLETKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/Trustlet.tkn.cert
 endif
@@ -94,7 +94,7 @@

PSPBTLDR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspBootLoader_prod_CZ.sbin
 PSPRCVR_FILE=$(top)/$(FIRMWARE_LOCATE)/PspRecoveryBootLoader_prod_CZ.sbin
-PSPSCUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs_prod_CZ.csbin
+PSPSECUREOS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspSecureOs_prod_CZ.csbin
 PSPTRUSTLETS_FILE=$(top)/$(FIRMWARE_LOCATE)/PspTrustlets_prod_CZ.cbin
 TRUSTLETKEY_FILE=$(top)/$(FIRMWARE_LOCATE)/TrustletKey_prod_CZ.sbin
 SMUFIRMWARE2_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware2_prod_CZ.sbin
@@ -120,7 +120,7 @@
 OPT_SMUFWM_FILE=$(call add_opt_prefix, $(SMUFWM_FILE), --smufirmware)
 OPT_PSPRCVR_FILE=$(call add_opt_prefix, $(PSPRCVR_FILE), --recovery)
 OPT_PUBSIGNEDKEY_FILE=$(call add_opt_prefix, $(PUBSIGNEDKEY_FILE), --rtmpubkey)
-OPT_PSPSCUREOS_FILE=$(call add_opt_prefix, $(PSPSCUREOS_FILE), --secureos)
+OPT_PSPSECUREOS_FILE=$(call add_opt_prefix, $(PSPSECUREOS_FILE), --secureos)
 OPT_PSPNVRAM_FILE=$(call add_opt_prefix, $(PSPNVRAM_FILE), --nvram)
 OPT_PSPSECUREDEBUG_FILE=$(call add_opt_prefix, $(PSPSECUREDEBUG_FILE), --securedebug)
 OPT_PSPTRUSTLETS_FILE=$(call add_opt_prefix, $(PSPTRUSTLETS_FILE), --trustlets)
@@ -135,7 +135,7 @@
    		$(call strip_quotes, $(PUBSIGNEDKEY_FILE)) \
    		$(call strip_quotes, $(PSPBTLDR_FILE)) \
    		$(call strip_quotes, $(PSPRCVR_FILE)) \
-			$(call strip_quotes, $(PSPSCUREOS_FILE)) \
+			$(call strip_quotes, $(PSPSECUREOS_FILE)) \
    		$(call strip_quotes, $(PSPNVRAM_FILE)) \
    		$(call strip_quotes, $(SMUFWM_FILE)) \
    		$(call strip_quotes, $(SMUSCS_FILE)) \
@@ -149,7 +149,7 @@
    		$(call strip_quotes, $(SMUFWM2_FILE)) \
    		$(call strip_quotes, $(SMUFWM2_FN_FILE)) \
    		$(call strip_quotes, $(PSPRCVR2_FILE)) \
-			$(call strip_quotes, $(PSPSCUREOS2_FILE)) \
+			$(call strip_quotes, $(PSPSECUREOS2_FILE)) \
    		$(call strip_quotes, $(PSPNVRAM2_FILE)) \
    		$(call strip_quotes, $(SMUSCS2_FILE)) \
    		$(call strip_quotes, $(PSPSECUREDEBUG2_FILE)) \
@@ -169,7 +169,7 @@
    	$(OPT_SMUFWM_FILE) \
    	$(OPT_PSPRCVR_FILE) \
    	$(OPT_PUBSIGNEDKEY_FILE) \
-		$(OPT_PSPSCUREOS_FILE) \
+		$(OPT_PSPSECUREOS_FILE) \
    	$(OPT_PSPNVRAM_FILE) \
    	$(OPT_PSPSECUREDEBUG_FILE) \
    	$(OPT_PSPTRUSTLETS_FILE) \
@@ -182,7 +182,7 @@
    	$(OPT_2SMUFWM_FN_FILE) \
    	$(OPT_2PSPRCVR_FILE) \
    	$(OPT_2PUBSIGNEDKEY_FILE) \
-		$(OPT_2PSPSCUREOS_FILE) \
+		$(OPT_2PSPSECUREOS_FILE) \
    	$(OPT_2PSPNVRAM_FILE) \
    	$(OPT_2PSPSECUREDEBUG_FILE) \
    	$(OPT_2PSPTRUSTLETS_FILE) \

Change in coreboot[master]: soc/amd/picasso: Fix typo of Kconfig setting

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45285 )

Change subject: soc/amd/picasso: Fix typo of Kconfig setting
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45285/5/src/soc/amd/stoneyridge/Mak... 
File src/soc/amd/stoneyridge/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45285/5/src/soc/amd/stoneyridge/Mak... 
PS5, Line 241: OPT_PSPSECUREOS_FILE
Looks like we can also remove this duplicate.

https://review.coreboot.org/c/coreboot/+/45285/5/src/southbridge/amd/pi/huds... 
File src/southbridge/amd/pi/hudson/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/45285/5/src/southbridge/amd/pi/huds... 
PS5, Line 152: PSPSECUREOS2_FILE
I don't see a secureos2 file.  Should this be removed?