Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55959 )
Change subject: trogdor: sc7180: Rename header files as per common QUP driver changes ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5: This CL seems like it should be split among the various sc7180 refactors previously in the CL stack. Please split it out accordingly so we don't get into a state where sc7180 is in a broken state.
File src/mainboard/google/trogdor/bootblock.c:
https://review.coreboot.org/c/coreboot/+/55959/comment/0569df8f_664c15f6 PS5, Line 5: #include <soc/qupv3_spi_common.h> Shouldn't this be included in the sc7180 spi driver refactor? Otherwise it won't compile at this point...
File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/55959/comment/05456ada_11e6e94a PS5, Line 12: #include <soc/qupv3_config_common.h> Seems like these should be included in their respective sc7180 driver refactors. Otherwise sc7180 will be at a point where it won't compile anymore.