Change in coreboot[master]: mb/google/brya: Add entry stubs of each stage

[EricR Lai (Code Review)]

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48063 )

Change subject: mb/google/brya: Add entry stubs of each stage
......................................................................

mb/google/brya: Add entry stubs of each stage

Add entry point stubs of each stage for Brya. More functionalities will
be added later.

BUG=b:174266035
TEST=Build Test

Signed-off-by: Eric Lai 
Change-Id: I44934c05ee32090b6e34648ee02f004c83e93d57
---
A src/mainboard/google/brya/Makefile.inc
A src/mainboard/google/brya/bootblock.c
A src/mainboard/google/brya/mainboard.c
A src/mainboard/google/brya/romstage.c
A src/mainboard/google/brya/variants/baseboard/include/gpio.h
A src/mainboard/google/brya/variants/baseboard/include/variants.h
6 files changed, 58 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/48063/1

diff --git a/src/mainboard/google/brya/Makefile.inc b/src/mainboard/google/brya/Makefile.inc
new file mode 100644
index 0000000..1680fd0
--- /dev/null
+++ b/src/mainboard/google/brya/Makefile.inc
@@ -0,0 +1,8 @@
+bootblock-y += bootblock.c
+
+romstage-y += romstage.c
+
+ramstage-y += mainboard.c
+
+subdirs-y += variants/baseboard
+CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include
diff --git a/src/mainboard/google/brya/bootblock.c b/src/mainboard/google/brya/bootblock.c
new file mode 100644
index 0000000..8a7b93a
--- /dev/null
+++ b/src/mainboard/google/brya/bootblock.c
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <bootblock_common.h>
+
+void bootblock_mainboard_init(void)
+{
+	/* TODO: Perform mainboard initialization */
+}
diff --git a/src/mainboard/google/brya/mainboard.c b/src/mainboard/google/brya/mainboard.c
new file mode 100644
index 0000000..53425a8
--- /dev/null
+++ b/src/mainboard/google/brya/mainboard.c
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <device/device.h>
+static void mainboard_init(void *chip_info)
+{
+	/* TODO: Perform mainboard initialization */
+}
+static void mainboard_enable(struct device *dev)
+{
+	/* TODO: Enable mainboard */
+}
+struct chip_operations mainboard_ops = {
+	.init = mainboard_init,
+	.enable_dev = mainboard_enable,
+};
diff --git a/src/mainboard/google/brya/romstage.c b/src/mainboard/google/brya/romstage.c
new file mode 100644
index 0000000..412edde
--- /dev/null
+++ b/src/mainboard/google/brya/romstage.c
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <fsp/api.h>
+#include <soc/romstage.h>
+void mainboard_memory_init_params(FSPM_UPD *memupd)
+{
+	/* ToDo : Fill FSP-M memory params */
+}
diff --git a/src/mainboard/google/brya/variants/baseboard/include/gpio.h b/src/mainboard/google/brya/variants/baseboard/include/gpio.h
new file mode 100644
index 0000000..e2874b6
--- /dev/null
+++ b/src/mainboard/google/brya/variants/baseboard/include/gpio.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __BASEBOARD_GPIO_H__
+#define __BASEBOARD_GPIO_H__
+
+#include <soc/gpe.h>
+#include <soc/gpio.h>
+
+#endif /* __BASEBOARD_GPIO_H__ */
+
diff --git a/src/mainboard/google/brya/variants/baseboard/include/variants.h b/src/mainboard/google/brya/variants/baseboard/include/variants.h
new file mode 100644
index 0000000..d16d3da
--- /dev/null
+++ b/src/mainboard/google/brya/variants/baseboard/include/variants.h
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __BASEBOARD_VARIANTS_H__
+#define __BASEBOARD_VARIANTS_H__
+
+#include <soc/gpio.h>
+#include <stdint.h>
+
+#endif /*__BASEBOARD_VARIANTS_H__ */

[EricR Lai (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48063

to look at the new patch set (#2).

Change subject: mb/google/brya: Add entry stubs of each stage
......................................................................

mb/google/brya: Add entry stubs of each stage

Add entry point stubs of each stage for Brya. More functionalities will
be added later.

BUG=b:174266035
TEST=Build Test

Signed-off-by: Eric Lai 
Change-Id: I44934c05ee32090b6e34648ee02f004c83e93d57
---
A src/mainboard/google/brya/Makefile.inc
A src/mainboard/google/brya/bootblock.c
A src/mainboard/google/brya/mainboard.c
A src/mainboard/google/brya/romstage.c
A src/mainboard/google/brya/variants/baseboard/include/gpio.h
A src/mainboard/google/brya/variants/baseboard/include/variants.h
6 files changed, 57 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/48063/2

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48063 )

Change subject: mb/google/brya: Add entry stubs of each stage
......................................................................

Patch Set 2:

I don't know why I don't have new line check in my server XD

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48063 )

Change subject: mb/google/brya: Add entry stubs of each stage
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48063/2/src/mainboard/google/brya/m... 
File src/mainboard/google/brya/mainboard.c:

https://review.coreboot.org/c/coreboot/+/48063/2/src/mainboard/google/brya/m... 
PS2, Line 2: 
I added the new line in the next CL 🙏

[EricR Lai (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48063

to look at the new patch set (#3).

Change subject: mb/google/brya: Add entry stubs of each stage
......................................................................

mb/google/brya: Add entry stubs of each stage

Add entry point stubs of each stage for Brya. More functionalities will
be added later.

BUG=b:174266035
TEST=Build Test

Signed-off-by: Eric Lai 
Change-Id: I44934c05ee32090b6e34648ee02f004c83e93d57
---
A src/mainboard/google/brya/Makefile.inc
A src/mainboard/google/brya/bootblock.c
A src/mainboard/google/brya/mainboard.c
A src/mainboard/google/brya/romstage.c
A src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h
A src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h
6 files changed, 61 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/48063/3

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48063 )

Change subject: mb/google/brya: Add entry stubs of each stage
......................................................................

Patch Set 4: Code-Review+2

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48063 )

Change subject: mb/google/brya: Add entry stubs of each stage
......................................................................

mb/google/brya: Add entry stubs of each stage

Add entry point stubs of each stage for Brya. More functionalities will
be added later.

BUG=b:174266035
TEST=Build Test

Signed-off-by: Eric Lai 
Change-Id: I44934c05ee32090b6e34648ee02f004c83e93d57
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48063
Reviewed-by: Tim Wawrzynczak 
Tested-by: build bot (Jenkins) 
---
A src/mainboard/google/brya/Makefile.inc
A src/mainboard/google/brya/bootblock.c
A src/mainboard/google/brya/mainboard.c
A src/mainboard/google/brya/romstage.c
A src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h
A src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h
6 files changed, 61 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/brya/Makefile.inc b/src/mainboard/google/brya/Makefile.inc
new file mode 100644
index 0000000..1680fd0
--- /dev/null
+++ b/src/mainboard/google/brya/Makefile.inc
@@ -0,0 +1,8 @@
+bootblock-y += bootblock.c
+
+romstage-y += romstage.c
+
+ramstage-y += mainboard.c
+
+subdirs-y += variants/baseboard
+CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include
diff --git a/src/mainboard/google/brya/bootblock.c b/src/mainboard/google/brya/bootblock.c
new file mode 100644
index 0000000..8a7b93a
--- /dev/null
+++ b/src/mainboard/google/brya/bootblock.c
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <bootblock_common.h>
+
+void bootblock_mainboard_init(void)
+{
+	/* TODO: Perform mainboard initialization */
+}
diff --git a/src/mainboard/google/brya/mainboard.c b/src/mainboard/google/brya/mainboard.c
new file mode 100644
index 0000000..3dc2c41
--- /dev/null
+++ b/src/mainboard/google/brya/mainboard.c
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <device/device.h>
+
+static void mainboard_init(void *chip_info)
+{
+	/* TODO: Perform mainboard initialization */
+}
+
+static void mainboard_enable(struct device *dev)
+{
+	/* TODO: Enable mainboard */
+}
+
+struct chip_operations mainboard_ops = {
+	.init = mainboard_init,
+	.enable_dev = mainboard_enable,
+};
diff --git a/src/mainboard/google/brya/romstage.c b/src/mainboard/google/brya/romstage.c
new file mode 100644
index 0000000..341df15
--- /dev/null
+++ b/src/mainboard/google/brya/romstage.c
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <fsp/api.h>
+#include <soc/romstage.h>
+
+void mainboard_memory_init_params(FSPM_UPD *memupd)
+{
+	/* ToDo : Fill FSP-M memory params */
+}
diff --git a/src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h
new file mode 100644
index 0000000..a708db1
--- /dev/null
+++ b/src/mainboard/google/brya/variants/baseboard/include/baseboard/gpio.h
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __BASEBOARD_GPIO_H__
+#define __BASEBOARD_GPIO_H__
+
+#include <soc/gpe.h>
+#include <soc/gpio.h>
+
+#endif /* __BASEBOARD_GPIO_H__ */
diff --git a/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h
new file mode 100644
index 0000000..d16d3da
--- /dev/null
+++ b/src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __BASEBOARD_VARIANTS_H__
+#define __BASEBOARD_VARIANTS_H__
+
+#include <soc/gpio.h>
+#include <stdint.h>
+
+#endif /*__BASEBOARD_VARIANTS_H__ */