Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76278?usp=email )
Change subject: nb/pi/00730F01: Rework nb resource reading
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/76278/comment/7fc9bc85_33721629 :
PS1, Line 112: *limit = ((temp & 0xffff0000) >> 16) << 24;
Do the shifts here work with u32 tmp ?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76278?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5685de63ff8971fc4873080e4b9542e6bbf58509
Gerrit-Change-Number: 76278
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 01 Aug 2023 10:33:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment