Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31469 )
Change subject: rmodule: Don't emit reloc for R_X86_64_PC64 ......................................................................
rmodule: Don't emit reloc for R_X86_64_PC64
Relocations for PC relative instructions must not emitted. As PC64 are unlikely with current code, it never was an issue.
Change-Id: Ife472a287ff15b1c04a516e25ff13221441fd122 Signed-off-by: Patrick Rudolph siro@das-labor.org Reviewed-on: https://review.coreboot.org/c/31469 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/cbfstool/rmodule.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/util/cbfstool/rmodule.c b/util/cbfstool/rmodule.c index f270e3e..817bc60 100644 --- a/util/cbfstool/rmodule.c +++ b/util/cbfstool/rmodule.c @@ -66,7 +66,6 @@
/* Only emit absolute relocations */ return (type == R_AMD64_64 || - type == R_AMD64_PC64 || type == R_AMD64_32S || type == R_AMD64_32); }