Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58899 )
Change subject: [RFC] ChromeOS: Add DECLARE_x_CROS_GPIOS() ......................................................................
Patch Set 2:
(8 comments)
File src/vendorcode/google/chromeos/chromeos.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173): https://review.coreboot.org/c/coreboot/+/58899/comment/2b0a1929_6e622436 PS2, Line 110: #define DECLARE_CROS_GPIOS(x) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173): https://review.coreboot.org/c/coreboot/+/58899/comment/7025e4bf_3f692b1c PS2, Line 110: #define DECLARE_CROS_GPIOS(x) \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173): https://review.coreboot.org/c/coreboot/+/58899/comment/537be0d4_690a3ae0 PS2, Line 111: const struct cros_gpio *variant_cros_gpios(size_t *num) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173): https://review.coreboot.org/c/coreboot/+/58899/comment/932da853_118059f6 PS2, Line 112: { \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173): https://review.coreboot.org/c/coreboot/+/58899/comment/93ed3d72_9889000d PS2, Line 117: #define DECLARE_WEAK_CROS_GPIOS(x) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173): https://review.coreboot.org/c/coreboot/+/58899/comment/e2cb07e8_88af9b39 PS2, Line 117: #define DECLARE_WEAK_CROS_GPIOS(x) \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173): https://review.coreboot.org/c/coreboot/+/58899/comment/2d1ec48a_d946e693 PS2, Line 118: const struct cros_gpio *__weak variant_cros_gpios(size_t *num) \ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132173): https://review.coreboot.org/c/coreboot/+/58899/comment/bb6a2935_e185db59 PS2, Line 119: { \ please, no space before tabs
-
build bot (Jenkins) (Code Review)