Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32838 )
Change subject: console: Add new function die_with_post_code() ......................................................................
console: Add new function die_with_post_code()
Add a new helper function die_with_post_code() that generates a post code and an error string prior to halting the CPU.
BUG=b:124401932 BRANCH=sarien TEST=build coreboot for sarien and arcada platforms
Change-Id: I87551d60b253dc13ff76f7898c1f112f573a00a2 Signed-off-by: Keith Short keithshort@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/32838 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/console/die.c M src/include/console/console.h 2 files changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/console/die.c b/src/console/die.c index 769e651..513d1c4 100644 --- a/src/console/die.c +++ b/src/console/die.c @@ -36,4 +36,11 @@ die_notify(); halt(); } + +/* Report a fatal error with a post code */ +void __noreturn die_with_post_code(uint8_t value, const char *msg) +{ + post_code(value); + die(msg); +} #endif diff --git a/src/include/console/console.h b/src/include/console/console.h index ed10807..082ba29 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -43,6 +43,7 @@ /* this function is weak and can be overridden by a mainboard function. */ void mainboard_post(u8 value); void __noreturn die(const char *msg); +void __noreturn die_with_post_code(uint8_t value, const char *msg);
/* * This function is weak and can be overridden to provide additional