Attention is currently required from: Máté Kukri.
Elyes Haouas has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/82053?usp=email )
Change subject: [WIP] OptiPlex 3050 Micro port ......................................................................
Patch Set 14:
(3 comments)
File src/mainboard/dell/optiplex_3050/romstage.c:
https://review.coreboot.org/c/coreboot/+/82053/comment/0e06d822_b86e8ce1?usp... : PS14, Line 3: #include <assert.h> maybe not used
https://review.coreboot.org/c/coreboot/+/82053/comment/1912251c_9f411cfb?usp... : PS14, Line 8: include <cbfs.h> maybe not used
File src/mainboard/dell/optiplex_3050/sch5555_ec.c:
https://review.coreboot.org/c/coreboot/+/82053/comment/4ced6eb8_cca98ea2?usp... : PS14, Line 11: uint8_t tmp = inb(SCH555x_EMI_IOBASE + 1); : outb(tmp, SCH555x_EMI_IOBASE + 1); not sure but maybe `pnp_unset_and_set_index` can be used ? see device/pnp.h