[S] Change in coreboot[main]: sb/intel/bd82x6x: Follow PCH BIOS spec - coreboot-gerrit

8 Oct 2023


      Attention is currently required from: Felix Held, Kyösti Mälkki.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78225?usp=email )
Change subject: sb/intel/bd82x6x: Follow PCH BIOS spec
......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/bd82x6x/early_pch.c:
https://review.coreboot.org/c/coreboot/+/78225/comment/05dcd1e7_f52714b6 :
PS3, Line 139: 0x1e58
...
might be good to add a define for this to avoid having a magic constant in here to make it a bit mor […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78225?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I865818c0c22194fffcb2bbdf8c43737b0dce2307
Gerrit-Change-Number: 78225
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 08 Oct 2023 11:09:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment