Change in coreboot[master]: cpu/x86/smm_module_loader.c: Clean up printing the CPU map

[Arthur Heymans (Code Review)]

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63473 )

Change subject: cpu/x86/smm_module_loader.c: Clean up printing the CPU map
......................................................................

cpu/x86/smm_module_loader.c: Clean up printing the CPU map

There is no reason to do this in a separate loop.

Change-Id: I7fe9f1004597602147aae72f4b754395b6b527cf
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63473
Tested-by: build bot (Jenkins) 
Reviewed-by: Elyes Haouas 
Reviewed-by: Angel Pons 
---
M src/cpu/x86/smm/smm_module_loader.c
1 file changed, 6 insertions(+), 18 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Elyes Haouas: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c
index 17c6779..9068435 100644
--- a/src/cpu/x86/smm/smm_module_loader.c
+++ b/src/cpu/x86/smm/smm_module_loader.c
@@ -126,38 +126,26 @@
    }

for (i = 0; i < num_cpus; i++) {
+		printk(BIOS_DEBUG, "CPU 0x%x\n", i);
    	cpus[i].smbase = base;
    	cpus[i].entry = base + smm_entry_offset;
+		printk(BIOS_DEBUG, "    smbase %lx  entry %lx\n", cpus[i].smbase,
+		       cpus[i].entry);
    	cpus[i].ss_start = cpus[i].entry + (smm_entry_offset - ss_size);
    	cpus[i].code_start = cpus[i].entry;
    	cpus[i].code_end = cpus[i].entry + stub_size;
+		printk(BIOS_DEBUG, "           ss_start %lx  code_end %lx\n", cpus[i].ss_start,
+		       cpus[i].code_end);
    	cpus[i].active = 1;
    	base -= ss_size;
    	seg_count++;
    	if (seg_count >= cpus_in_segment) {
    		base -= smm_entry_offset;
    		seg_count = 0;
+			printk(BIOS_DEBUG, "-------------NEW CODE SEGMENT --------------\n");
    	}
    }

-	if (CONFIG_DEFAULT_CONSOLE_LOGLEVEL >= BIOS_DEBUG) {
-		seg_count = 0;
-		for (i = 0; i < num_cpus; i++) {
-			printk(BIOS_DEBUG, "CPU 0x%x\n", i);
-			printk(BIOS_DEBUG,
-				"    smbase %lx  entry %lx\n",
-				cpus[i].smbase, cpus[i].entry);
-			printk(BIOS_DEBUG,
-				"           ss_start %lx  code_end %lx\n",
-				cpus[i].ss_start, cpus[i].code_end);
-			seg_count++;
-			if (seg_count >= cpus_in_segment) {
-				printk(BIOS_DEBUG,
-					"-------------NEW CODE SEGMENT --------------\n");
-				seg_count = 0;
-			}
-		}
-	}
    return 1;
 }