Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28644 )
Change subject: mb/lenovo/r500: Add mainboard ......................................................................
Patch Set 7: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/28644/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/28644/7//COMMIT_MSG@17 PS7, Line 17: (Needs SeaBIOS with sercon disabled) I think this isn't needed anymore
https://review.coreboot.org/#/c/28644/7//COMMIT_MSG@41 PS7, Line 41: Debian 9, Linux 4.9 Was this booted via USB?
https://review.coreboot.org/#/c/28644/7/src/mainboard/lenovo/t400/Kconfig File src/mainboard/lenovo/t400/Kconfig:
https://review.coreboot.org/#/c/28644/7/src/mainboard/lenovo/t400/Kconfig@13 PS7, Line 13: select BOARD_ROMSIZE_KB_8192 : select BOARD_ROMSIZE_KB_4096 if BOARD_LENOVO_R500 Doesn't this conflict?
-
Angel Pons (Code Review)