David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49002 )
Change subject: mb/google/volteer/var/voema: Enable IPU for voema ......................................................................
mb/google/volteer/var/voema: Enable IPU for voema
Enable IPU for voema for MIPI camera.
BUG=169551066 TEST=IPU is enabled and shows in lspci.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I34736bffd4dc61a840003afe5afd6a9c8dc32e62 --- M src/mainboard/google/volteer/variants/voema/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/49002/1
diff --git a/src/mainboard/google/volteer/variants/voema/overridetree.cb b/src/mainboard/google/volteer/variants/voema/overridetree.cb index f612beb..daea432 100644 --- a/src/mainboard/google/volteer/variants/voema/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voema/overridetree.cb @@ -17,6 +17,7 @@ register "PcieClkSrcUsage[3]" = "PCIE_CLK_NOTUSED"
device domain 0 on + device ref ipu on end # IPU device ref i2c0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49002 )
Change subject: mb/google/volteer/var/voema: Enable IPU for voema ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/49002/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49002/1//COMMIT_MSG@11 PS1, Line 11: 169551066 b:169551066
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49002
to look at the new patch set (#2).
Change subject: mb/google/volteer/var/voema: Enable IPU for voema ......................................................................
mb/google/volteer/var/voema: Enable IPU for voema
Enable IPU for voema for MIPI camera.
BUG=b:169551066 TEST=IPU is enabled and shows in lspci.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I34736bffd4dc61a840003afe5afd6a9c8dc32e62 --- M src/mainboard/google/volteer/variants/voema/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/49002/2
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49002 )
Change subject: mb/google/volteer/var/voema: Enable IPU for voema ......................................................................
Patch Set 2:
(1 comment)
Thanks.
https://review.coreboot.org/c/coreboot/+/49002/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49002/1//COMMIT_MSG@11 PS1, Line 11: 169551066
b:169551066
Done
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49002 )
Change subject: mb/google/volteer/var/voema: Enable IPU for voema ......................................................................
Patch Set 2: Code-Review+1
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49002 )
Change subject: mb/google/volteer/var/voema: Enable IPU for voema ......................................................................
mb/google/volteer/var/voema: Enable IPU for voema
Enable IPU for voema for MIPI camera.
BUG=b:169551066 TEST=IPU is enabled and shows in lspci.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I34736bffd4dc61a840003afe5afd6a9c8dc32e62 Reviewed-on: https://review.coreboot.org/c/coreboot/+/49002 Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Caveh Jalali caveh@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/voema/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/voema/overridetree.cb b/src/mainboard/google/volteer/variants/voema/overridetree.cb index f612beb..daea432 100644 --- a/src/mainboard/google/volteer/variants/voema/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voema/overridetree.cb @@ -17,6 +17,7 @@ register "PcieClkSrcUsage[3]" = "PCIE_CLK_NOTUSED"
device domain 0 on + device ref ipu on end # IPU device ref i2c0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
-
Caveh Jalali (Code Review) -
David Wu (Code Review)
-
Paul Fagerburg (Code Review)
-
Tim Wawrzynczak (Code Review)