Change in ...coreboot[master]: soc/intel/braswell: Correct serial IRQ support - coreboot-gerrit

2 Apr 2019


      Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29398 )
Change subject: soc/intel/braswell: Correct serial IRQ support
......................................................................
Patch Set 12:
(1 comment)
Update covering the remarks.
https://review.coreboot.org/#/c/29398/10/src/soc/intel/braswell/southcluster... 
File src/soc/intel/braswell/southcluster.c:
https://review.coreboot.org/#/c/29398/10/src/soc/intel/braswell/southcluster... 
PS10, Line 97: (pci_read_config32(dev, IBASE) & ~0xF)
...
Why use ILB_BASE_ADDRESS above and then this here?
Correct in new patch. Use same construction
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29398
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7844cad69dc0563fa6109d779d0afb7c2edd7245
Gerrit-Change-Number: 29398
Gerrit-PatchSet: 12
Gerrit-Owner: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Hannah Williams hannah.williams@intel.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 02 Apr 2019 13:33:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment