Attention is currently required from: Julius Werner, Rob Barnes, Yu-Ping Wu, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59082 )
Change subject: mb/google/guybrush: Add variant_espi_gpio_table
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/guybrush/verstage.c:
https://review.coreboot.org/c/coreboot/+/59082/comment/3312b293_4aaaaefd
PS1, Line 64: gpio_configure_pads
Do we need to setup the I2C TPM GPIOs?
File src/security/vboot/vboot_common.h:
https://review.coreboot.org/c/coreboot/+/59082/comment/cb980f51_0ec137fc
PS1, Line 46: verstage_mainboard_espi_init
I would put this in a Cezanne specific header. I don't think we will need this for any other platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59082
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0cd439f207df7c27575ae363b207293d40485bf8
Gerrit-Change-Number: 59082
Gerrit-PatchSet: 1
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 10 Nov 2021 16:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment