Change in ...coreboot[master]: lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Subrata Banik (Code Review)

10 May 2019 10 May '19

1 a.m.

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32722

Change subject: lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id ......................................................................

lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id

This patch ensures start_cpu() function to store default_apic_id using common cpu_add_map_entry() function to make cpu_index() implementation generic.

BRANCH=none BUG=b:79562868

Change-Id: Iac4d6e9e6e6f9ba644335b4b70da8689c405f638 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/cpu/x86/lapic/lapic_cpu_init.c 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/32722/1

diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index 3ad1f0a..ab45142 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -291,6 +291,7 @@ info = (struct cpu_info *)stack_top; info->index = index; info->cpu = cpu; + cpu_add_map_entry(info); thread_init_cpu_info_non_bsp(info);

/* Advertise the new stack and index to start_cpu */

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Subrata Banik (Code Review)

10 May 10 May

4:34 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32722

to look at the new patch set (#2).

Change subject: lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id ......................................................................

lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id

This patch ensures start_cpu() function to store default_apic_id using common cpu_add_map_entry() function to make cpu_index() implementation generic.

BRANCH=none BUG=b:79562868

Change-Id: Iac4d6e9e6e6f9ba644335b4b70da8689c405f638 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/cpu/x86/lapic/lapic_cpu_init.c 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/32722/2

Nico Huber (Code Review)

6:03 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32722 )

Change subject: lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32722/2/src/cpu/x86/lapic/lapic_cpu_init.c File src/cpu/x86/lapic/lapic_cpu_init.c:

https://review.coreboot.org/#/c/32722/2/src/cpu/x86/lapic/lapic_cpu_init.c@5... PS2, Line 552: info->cpu = alloc_find_dev(cpu_bus, &cpu_path); Add another call here for the BSP.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac4d6e9e6e6f9ba644335b4b70da8689c405f638 Gerrit-Change-Number: 32722 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 10 May 2019 13:03:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Subrata Banik (Code Review)

7:42 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32722 )

Change subject: lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32722/2/src/cpu/x86/lapic/lapic_cpu_init.c File src/cpu/x86/lapic/lapic_cpu_init.c:

https://review.coreboot.org/#/c/32722/2/src/cpu/x86/lapic/lapic_cpu_init.c@5... PS2, Line 552: info->cpu = alloc_find_dev(cpu_bus, &cpu_path);

...

Add another call here for the BSP.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac4d6e9e6e6f9ba644335b4b70da8689c405f638 Gerrit-Change-Number: 32722 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 10 May 2019 14:42:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Subrata Banik (Code Review)

7:42 a.m.

Hello Aaron Durbin, Aamir Bohra, Rizwan Qureshi, build bot (Jenkins), Nico Huber, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32722

to look at the new patch set (#3).

Change subject: lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id ......................................................................

lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id

This patch ensures start_cpu() function to store default_apic_id using common cpu_add_map_entry() function to make cpu_index() implementation generic.

BRANCH=none BUG=b:79562868

Change-Id: Iac4d6e9e6e6f9ba644335b4b70da8689c405f638 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/cpu/x86/lapic/lapic_cpu_init.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/32722/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/32722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac4d6e9e6e6f9ba644335b4b70da8689c405f638 Gerrit-Change-Number: 32722 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

11 May 11 May

5:44 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32722 )

Change subject: lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id ......................................................................

Patch Set 3: Code-Review+2

This looks correct to me, but I would appreciate a second opinion by somebody more familiar with this code.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac4d6e9e6e6f9ba644335b4b70da8689c405f638 Gerrit-Change-Number: 32722 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 11 May 2019 12:44:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Subrata Banik (Code Review)

12 May 12 May

7:07 p.m.

Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32722 )

Change subject: lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id ......................................................................

lapic/lapic_cpu_init: Add cpu_add_map_entry() to store default_apic_id

This patch ensures start_cpu() function to store default_apic_id using common cpu_add_map_entry() function to make cpu_index() implementation generic.

BRANCH=none BUG=b:79562868

Change-Id: Iac4d6e9e6e6f9ba644335b4b70da8689c405f638 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32722 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/cpu/x86/lapic/lapic_cpu_init.c 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index 3ad1f0a..0f73e71 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -291,6 +291,7 @@ info = (struct cpu_info *)stack_top; info->index = index; info->cpu = cpu; + cpu_add_map_entry(info->index); thread_init_cpu_info_non_bsp(info);

/* Advertise the new stack and index to start_cpu */ @@ -549,6 +550,7 @@

/* Find the device structure for the boot CPU */ info->cpu = alloc_find_dev(cpu_bus, &cpu_path); + cpu_add_map_entry(info->index);

// why here? In case some day we can start core1 in amd_sibling_init if (is_smp_boot())

-- To view, visit https://review.coreboot.org/c/coreboot/+/32722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac4d6e9e6e6f9ba644335b4b70da8689c405f638 Gerrit-Change-Number: 32722 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2015

days inactive

2018

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Nico Huber (Code Review)
Subrata Banik (Code Review)