Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/28469 )
Change subject: x86/acpi: Add APEI definitions
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28469/1/src/arch/x86/include/arch/acpi.h
File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/#/c/28469/1/src/arch/x86/include/arch/acpi.h@693
PS1, Line 693: /* zero or more Generic Error Data Entries */
I don't understand what this comment is referring to.
The "zero or more" part? That odd phrase came from the spec but I can make it better.
--
To view, visit
https://review.coreboot.org/28469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9f4e506080285a7c3de6a223632c6f70933e66c
Gerrit-Change-Number: 28469
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Tue, 04 Sep 2018 22:18:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No