Change in coreboot[master]: soc/intel/broadwell: Guard MCHBAR macro parameters

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

13 Oct 2020 13 Oct '20

3:28 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46336 )

Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................

soc/intel/broadwell: Guard MCHBAR macro parameters

Add brackets around the parameters to avoid operation order problems.

Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.

Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/include/soc/systemagent.h 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/46336/1

diff --git a/src/soc/intel/broadwell/include/soc/systemagent.h b/src/soc/intel/broadwell/include/soc/systemagent.h index 52d386b..6f475a5 100644 --- a/src/soc/intel/broadwell/include/soc/systemagent.h +++ b/src/soc/intel/broadwell/include/soc/systemagent.h @@ -80,9 +80,9 @@

/* MCHBAR */

-#define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + x)) -#define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + x)) -#define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + x)) +#define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + (x))) +#define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + (x))) +#define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + (x)))

#define MCHBAR_PEI_VERSION 0x5034

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

build bot (Jenkins) (Code Review)

13 Oct 13 Oct

3:33 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46336 )

Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/c/coreboot/+/46336/1/src/soc/intel/broadwell/inc... File src/soc/intel/broadwell/include/soc/systemagent.h:

https://review.coreboot.org/c/coreboot/+/46336/1/src/soc/intel/broadwell/inc... PS1, Line 83: #define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/1/src/soc/intel/broadwell/inc... PS1, Line 84: #define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/1/src/soc/intel/broadwell/inc... PS1, Line 85: #define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

-- To view, visit https://review.coreboot.org/c/coreboot/+/46336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Gerrit-Change-Number: 46336 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 13 Oct 2020 12:33:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

10:42 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46336 )

Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/46336/2/src/soc/intel/broadwell/inc... File src/soc/intel/broadwell/include/soc/systemagent.h:

https://review.coreboot.org/c/coreboot/+/46336/2/src/soc/intel/broadwell/inc... PS2, Line 83: #define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/2/src/soc/intel/broadwell/inc... PS2, Line 84: #define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/2/src/soc/intel/broadwell/inc... PS2, Line 85: #define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

-- To view, visit https://review.coreboot.org/c/coreboot/+/46336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Gerrit-Change-Number: 46336 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 13 Oct 2020 19:42:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

14 Oct 14 Oct

1:12 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46336 )

Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/46336/3/src/soc/intel/broadwell/inc... File src/soc/intel/broadwell/include/soc/systemagent.h:

https://review.coreboot.org/c/coreboot/+/46336/3/src/soc/intel/broadwell/inc... PS3, Line 83: #define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/3/src/soc/intel/broadwell/inc... PS3, Line 84: #define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/3/src/soc/intel/broadwell/inc... PS3, Line 85: #define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

-- To view, visit https://review.coreboot.org/c/coreboot/+/46336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Gerrit-Change-Number: 46336 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 13 Oct 2020 22:12:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

17 Oct 17 Oct

6:29 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46336 )

Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Gerrit-Change-Number: 46336 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 17 Oct 2020 15:29:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

6:58 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46336 )

Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/46336/4/src/soc/intel/broadwell/inc... File src/soc/intel/broadwell/include/soc/systemagent.h:

https://review.coreboot.org/c/coreboot/+/46336/4/src/soc/intel/broadwell/inc... PS4, Line 83: #define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/4/src/soc/intel/broadwell/inc... PS4, Line 84: #define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/4/src/soc/intel/broadwell/inc... PS4, Line 85: #define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

-- To view, visit https://review.coreboot.org/c/coreboot/+/46336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Gerrit-Change-Number: 46336 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 17 Oct 2020 15:58:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

8:46 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46336 )

Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/c/coreboot/+/46336/5/src/soc/intel/broadwell/inc... File src/soc/intel/broadwell/include/soc/systemagent.h:

https://review.coreboot.org/c/coreboot/+/46336/5/src/soc/intel/broadwell/inc... PS5, Line 83: #define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/5/src/soc/intel/broadwell/inc... PS5, Line 84: #define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/5/src/soc/intel/broadwell/inc... PS5, Line 85: #define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

-- To view, visit https://review.coreboot.org/c/coreboot/+/46336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Gerrit-Change-Number: 46336 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 17 Oct 2020 17:46:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

9:49 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46336 )

Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/c/coreboot/+/46336/5/src/soc/intel/broadwell/inc... File src/soc/intel/broadwell/include/soc/systemagent.h:

-- To view, visit https://review.coreboot.org/c/coreboot/+/46336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Gerrit-Change-Number: 46336 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 17 Oct 2020 18:49:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

23 Oct 23 Oct

12:30 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46336 )

Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................

Patch Set 8:

(3 comments)

https://review.coreboot.org/c/coreboot/+/46336/8/src/soc/intel/broadwell/inc... File src/soc/intel/broadwell/include/soc/systemagent.h:

https://review.coreboot.org/c/coreboot/+/46336/8/src/soc/intel/broadwell/inc... PS8, Line 83: #define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/8/src/soc/intel/broadwell/inc... PS8, Line 84: #define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46336/8/src/soc/intel/broadwell/inc... PS8, Line 85: #define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses

-- To view, visit https://review.coreboot.org/c/coreboot/+/46336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Gerrit-Change-Number: 46336 Gerrit-PatchSet: 8 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 22 Oct 2020 21:30:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

5:45 p.m.

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46336 )

Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................

soc/intel/broadwell: Guard MCHBAR macro parameters

Add brackets around the parameters to avoid operation order problems.

Tested with BUILD_TIMELESS=1, Purism Librem 13 v1 remains identical.

Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46336 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/broadwell/include/soc/systemagent.h 1 file changed, 3 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

diff --git a/src/soc/intel/broadwell/include/soc/systemagent.h b/src/soc/intel/broadwell/include/soc/systemagent.h index c2c5cc8..f81d5a0 100644 --- a/src/soc/intel/broadwell/include/soc/systemagent.h +++ b/src/soc/intel/broadwell/include/soc/systemagent.h @@ -80,9 +80,9 @@

/* MCHBAR */

#define MCHBAR_PEI_VERSION 0x5034 #define BIOS_RESET_CPL 0x5da8

-- To view, visit https://review.coreboot.org/c/coreboot/+/46336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6efbe70d2bb3ad776a2566365afa66afab51584e Gerrit-Change-Number: 46336 Gerrit-PatchSet: 9 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1550

days inactive

1560

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
build bot (Jenkins) (Code Review)
Nico Huber (Code Review)