Attention is currently required from: Cliff Huang, Eran Mitrani, Eric Lai, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Ravishankar Sarawadi, Tarun, Utkarsh H Patel.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78163?usp=email )
Change subject: soc/intel/meteorlake: Update TBT PCIe Reg Map offsets for QS
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78163/comment/f2347cc1_f82f1744 :
PS6, Line 14:
Please mention the datasheet name and revision.
File src/soc/intel/meteorlake/acpi/tcss_pcierp.asl:
https://review.coreboot.org/c/coreboot/+/78163/comment/0512bbf3_ae1c7fa6 :
PS6, Line 54: Offset(0xBA8), /* 0xBA8, MPC - Miscellaneous Port Configuration Register */
: , 30,
: HPEX, 1, /* 30, Hot Plug SCI Enable */
: PMEX, 1, /* 31, Power Management SCI Enable */
: Offset(0xBB2), /* 0xBB2, RPPGEN - Root Port Power Gating Enable */
: , 2,
: L23E, 1, /* 2, L23_Rdy Entry Request (L23ER) */
: L23R, 1, /* 3, L23_Rdy to Detect Transition (L23R2DT) */
In Gerrit, the `/*` are not correctly aligned with line 53.
https://review.coreboot.org/c/coreboot/+/78163/comment/caa3a6fc_6085b5b1 :
PS6, Line 70: Offset(0xBAC), /* 0xBAC, SMSCS - SMI/SCI Status Register */
Please align `/*`.
https://review.coreboot.org/c/coreboot/+/78163/comment/6efe7499_58279ff0 :
PS6, Line 67: #if CONFIG(SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON)
: Offset(0xDC), /* 0xDC, SMSCS - SMI/SCI Status Register */
: #else
: Offset(0xBAC), /* 0xBAC, SMSCS - SMI/SCI Status Register */
: #endif
Maybe define a macro for SMSCS?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78163?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0497f7108ef5046c2694aece232263582514a0c5
Gerrit-Change-Number: 78163
Gerrit-PatchSet: 6
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 05 Oct 2023 19:37:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment