[S] Change in coreboot[main]: nb/intel/sandybridge/sandybridge.h: Clean up - coreboot-gerrit

31 May 2024


      Attention is currently required from: Angel Pons, Felix Held, Felix Singer.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/70698?usp=email )
Change subject: nb/intel/sandybridge/sandybridge.h: Clean up
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/intel/sandybridge/sandybridge.h:
https://review.coreboot.org/c/coreboot/+/70698/comment/245ffd79_3d151847?usp... :
PS3, Line 13: /* Everything below this line is ignored in the DSDT */
...
this isn't exactly obvious when only looking at this file, so i'd also like to keep this comment. […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/70698?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibf354b3fcd6e1986e7656abc1bffcb974d74219f
Gerrit-Change-Number: 70698
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 01 Jun 2024 06:57:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Comment-In-Reply-To: Elyes Haouas ehaouas@noos.fr