Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43480 )
Change subject: soc/intel/jasperlake: Clean up report_cpu_info() function
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/43480/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43480/4//COMMIT_MSG@7
PS4, Line 7: jasperlake
How about doing this for all other platforms as well? In separate changes, that is.
https://review.coreboot.org/c/coreboot/+/43480/4//COMMIT_MSG@9
PS4, Line 9: inorder
in order
https://review.coreboot.org/c/coreboot/+/43480/4//COMMIT_MSG@9
PS4, Line 9: makes reuse of
uses the
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I532e05d9bb71fdff24e086e81ec72ffe8dc2c22d
Gerrit-Change-Number: 43480
Gerrit-PatchSet: 4
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 24 Jul 2020 22:55:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment