Hello Felix Singer,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/44180
to review the following change.
Change subject: payloads/nvramcui: Fix `make clean` ......................................................................
payloads/nvramcui: Fix `make clean`
After `make clean` a new build should not be based on stale artifacts. Hence we have to remove them.
Change-Id: I540a83a6c87b843b1c4c9c55990bf3e91fe90d79 Signed-off-by: Nico Huber nico.huber@secunet.com --- M payloads/nvramcui/Makefile 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/44180/1
diff --git a/payloads/nvramcui/Makefile b/payloads/nvramcui/Makefile index bf7053b..269d558 100644 --- a/payloads/nvramcui/Makefile +++ b/payloads/nvramcui/Makefile @@ -26,9 +26,9 @@ endif
clean: - rm -f nvramcui.elf + rm -rf build libpayload nvramcui.elf
distclean: clean - rm -rf build libpayload .config .config.old + rm -rf .config .config.old
.PHONY: all clean distclean
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44180 )
Change subject: payloads/nvramcui: Fix `make clean` ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44180 )
Change subject: payloads/nvramcui: Fix `make clean` ......................................................................
payloads/nvramcui: Fix `make clean`
After `make clean` a new build should not be based on stale artifacts. Hence we have to remove them.
Change-Id: I540a83a6c87b843b1c4c9c55990bf3e91fe90d79 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44180 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M payloads/nvramcui/Makefile 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/payloads/nvramcui/Makefile b/payloads/nvramcui/Makefile index bf7053b..269d558 100644 --- a/payloads/nvramcui/Makefile +++ b/payloads/nvramcui/Makefile @@ -26,9 +26,9 @@ endif
clean: - rm -f nvramcui.elf + rm -rf build libpayload nvramcui.elf
distclean: clean - rm -rf build libpayload .config .config.old + rm -rf .config .config.old
.PHONY: all clean distclean
-
Angel Pons (Code Review) -
Nico Huber (Code Review)