Change in coreboot[master]: volteer: Create halvor variant

[Frank Wu (Code Review)]

Frank Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference
board by copying the template files to a new directory named
for the variant.

(Auto-Generated by create_coreboot_variant.sh version 3.0.0).

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
3 files changed, 19 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39667/1

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index 5bc4876..df90663 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -57,6 +57,7 @@
    string
    default "Ripto" if BOARD_GOOGLE_RIPTO
    default "Volteer" if BOARD_GOOGLE_VOLTEER
+	default "Halvor" if BOARD_GOOGLE_HALVOR

config MAX_CPUS
    int
@@ -70,5 +71,6 @@
    string
    default "ripto" if BOARD_GOOGLE_RIPTO
    default "volteer" if BOARD_GOOGLE_VOLTEER
+	default "halvor" if BOARD_GOOGLE_HALVOR

endif # BOARD_GOOGLE_BASEBOARD_VOLTEER
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name
index d60dfb4..7246ea5 100644
--- a/src/mainboard/google/volteer/Kconfig.name
+++ b/src/mainboard/google/volteer/Kconfig.name
@@ -7,3 +7,7 @@
 config BOARD_GOOGLE_RIPTO
    bool "-> Ripto"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
+
+config BOARD_GOOGLE_HALVOR
+	bool "-> Halvor"
+	select BOARD_GOOGLE_BASEBOARD_VOLTEER
diff --git a/src/mainboard/google/volteer/variants/halvor/Makefile.inc b/src/mainboard/google/volteer/variants/halvor/Makefile.inc
new file mode 100644
index 0000000..38cf728
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/halvor/Makefile.inc
@@ -0,0 +1,13 @@
+## This file is part of the coreboot project.
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; version 2 of the License.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+
+SPD_SOURCES =

[Frank Wu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Nick Vaccaro, Srinidhi N Kaushik, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39667

to look at the new patch set (#2).

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference
board by copying the template files to a new directory named
for the variant.

(Auto-Generated by create_coreboot_variant.sh version 3.0.0).

Copy gpio.c and overridetree.cb from ripto for initializing.

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
A src/mainboard/google/volteer/variants/halvor/gpio.c
A src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
A src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
A src/mainboard/google/volteer/variants/halvor/overridetree.cb
7 files changed, 540 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39667/2

[Frank Wu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Nick Vaccaro, Srinidhi N Kaushik, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39667

to look at the new patch set (#3).

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference
board by copying the template files to a new directory named
for the variant.

(Auto-Generated by create_coreboot_variant.sh version 3.0.0).

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
A src/mainboard/google/volteer/variants/halvor/gpio.c
A src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
A src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
A src/mainboard/google/volteer/variants/halvor/overridetree.cb
7 files changed, 125 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39667/3

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39667/3/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/39667/3/src/mainboard/google/voltee... 
PS3, Line 2: 
remove warp line

[Frank Wu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Nick Vaccaro, Srinidhi N Kaushik, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39667

to look at the new patch set (#4).

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference
board by copying the template files to a new directory named
for the variant.

(Auto-Generated by create_coreboot_variant.sh version 3.0.0).

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
A src/mainboard/google/volteer/variants/halvor/gpio.c
A src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
A src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
A src/mainboard/google/volteer/variants/halvor/overridetree.cb
7 files changed, 118 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39667/4

[Frank Wu (Code Review)]

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39667/3/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/39667/3/src/mainboard/google/voltee... 
PS3, Line 2:
> remove warp line

Done

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39667/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig:

https://review.coreboot.org/c/coreboot/+/39667/4/src/mainboard/google/voltee... 
PS4, Line 60: Halvor
should we be sorting these alphabetically?

[Frank Wu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Nick Vaccaro, Srinidhi N Kaushik, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39667

to look at the new patch set (#5).

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference
board by copying the template files to a new directory named
for the variant.

(Auto-Generated by create_coreboot_variant.sh version 3.0.0).

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
A src/mainboard/google/volteer/variants/halvor/gpio.c
A src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
A src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
A src/mainboard/google/volteer/variants/halvor/overridetree.cb
7 files changed, 118 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39667/5

[Frank Wu (Code Review)]

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39667/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig:

https://review.coreboot.org/c/coreboot/+/39667/4/src/mainboard/google/voltee... 
PS4, Line 60: Halvor
> should we be sorting these alphabetically?

Done, thanks.

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39667/5/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/39667/5/src/mainboard/google/voltee... 
PS5, Line 11: config BOARD_GOOGLE_HALVOR
alphabetical order here as well, please.
sorry, volteer and ripto should have been swapped as well.

[Frank Wu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Nick Vaccaro, Srinidhi N Kaushik, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39667

to look at the new patch set (#6).

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference
board by copying the template files to a new directory named
for the variant.

(Auto-Generated by create_coreboot_variant.sh version 3.0.0).

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
A src/mainboard/google/volteer/variants/halvor/gpio.c
A src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
A src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
A src/mainboard/google/volteer/variants/halvor/overridetree.cb
7 files changed, 118 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39667/6

[Frank Wu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Nick Vaccaro, Srinidhi N Kaushik, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39667

to look at the new patch set (#7).

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference
board by copying the template files to a new directory named
for the variant.

(Auto-Generated by create_coreboot_variant.sh version 3.0.0).

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
A src/mainboard/google/volteer/variants/halvor/gpio.c
A src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
A src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
A src/mainboard/google/volteer/variants/halvor/overridetree.cb
7 files changed, 120 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39667/7

[Frank Wu (Code Review)]

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 7:

(1 comment)
> Patch Set 5:
>
> (1 comment)

https://review.coreboot.org/c/coreboot/+/39667/5/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/39667/5/src/mainboard/google/voltee... 
PS5, Line 11: config BOARD_GOOGLE_HALVOR
> alphabetical order here as well, please. […]

Sorry, I miss that.
Thanks.

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 7: Code-Review+1

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 7: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG@9 
PS7, Line 9: Create the halvor variant of the volteer reference
           : board by copying the template files to a new directory named
           : for the variant.
Please re-flow for 72/75 character line length.

https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG@13 
PS7, Line 13: (Auto-Generated by create_coreboot_variant.sh version 3.0.0).
Please remove the brackets ().

https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG@13 
PS7, Line 13: Auto-Generated
Auto-generated …

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 7:

@Marco, maybe we can change the auto commit to a better style?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 7: Code-Review+1

(4 comments)

https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

PS7: 
Please use SPDX:

## SPDX-License-Identifier: GPL-2.0-only
 ## This file is part of the coreboot project.

https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/gpio.c:

https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... 
PS7, Line 1: /*
           :  * This file is part of the coreboot project.
           :  *
           :  * Copyright 2020 Google LLC
           :  *
           :  * This program is free software; you can redistribute it and/or modify
           :  * it under the terms of the GNU General Public License as published by
           :  * the Free Software Foundation; version 2 of the License.
           :  *
           :  * This program is distributed in the hope that it will be useful,
           :  * but WITHOUT ANY WARRANTY; without even the implied warranty of
           :  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
           :  * GNU General Public License for more details.
           :  */
Please use SPDX:

/* SPDX-License-Identifier: GPL-2.0-only */
 /* This file is part of the coreboot project. */

https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/include/variant/ec.h:

PS7: 
Please use SPDX:

/* SPDX-License-Identifier: GPL-2.0-only */
 /* This file is part of the coreboot project. */

https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h:

PS7: 
Please use SPDX:

/* SPDX-License-Identifier: GPL-2.0-only */
 /* This file is part of the coreboot project. */

[Frank Wu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Angel Pons, Marco Chen, Nick Vaccaro, Srinidhi N Kaushik, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39667

to look at the new patch set (#8).

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference
board by copying the template files to a new directory named
for the variant.

(Auto-Generated by create_coreboot_variant.sh version 3.0.0).

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
A src/mainboard/google/volteer/variants/halvor/gpio.c
A src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
A src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
A src/mainboard/google/volteer/variants/halvor/overridetree.cb
7 files changed, 73 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39667/8

[Frank Wu (Code Review)]

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 8:

(4 comments)

https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

PS7:
> Please use SPDX: […]

Done

https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/gpio.c:

https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... 
PS7, Line 1: /*
           :  * This file is part of the coreboot project.
           :  *
           :  * Copyright 2020 Google LLC
           :  *
           :  * This program is free software; you can redistribute it and/or modify
           :  * it under the terms of the GNU General Public License as published by
           :  * the Free Software Foundation; version 2 of the License.
           :  *
           :  * This program is distributed in the hope that it will be useful,
           :  * but WITHOUT ANY WARRANTY; without even the implied warranty of
           :  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
           :  * GNU General Public License for more details.
           :  */
> Please use SPDX: […]

Done

https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/include/variant/ec.h:

PS7:
> Please use SPDX: […]

Done

https://review.coreboot.org/c/coreboot/+/39667/7/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h:

PS7:
> Please use SPDX: […]

Done

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 8: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 8: Code-Review+1

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 8: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
PS8, Line 4: SPD_SOURCES =
Paul - I don't think this should be required anymore.

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/gpio.c:

PS8: 
Just a note: I know this is using a script to copy minimal files required for building this target. But, you will have to revisit this file to see if you really need variant_base_gpio_table() or you can make use to the gpio table provided by baseboard with some overrides here.

Similar comment for variant_cros_gpios() and variant_early_gpio_table(). It might be possible to reuse some of these from baseboard.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 8: Code-Review+2

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 8: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
PS8, Line 4: SPD_SOURCES =
> Paul - I don't think this should be required anymore.

Much like gpio.c, it's a placeholder. After the initial commit, they will need to come back and add SPDs to the makefile, so we may as well have a spot ready for it.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
PS8, Line 4: SPD_SOURCES =
> Much like gpio.c, it's a placeholder. […]

Okay sounds good.

[Frank Wu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Angel Pons, Marco Chen, Nick Vaccaro, Srinidhi N Kaushik, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39667

to look at the new patch set (#9).

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference board by copying the
template files to a new directory named for the variant.

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
A src/mainboard/google/volteer/variants/halvor/gpio.c
A src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
A src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
A src/mainboard/google/volteer/variants/halvor/overridetree.cb
7 files changed, 73 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39667/9

[Frank Wu (Code Review)]

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 9:

(4 comments)

https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG@9 
PS7, Line 9: Create the halvor variant of the volteer reference
           : board by copying the template files to a new directory named
           : for the variant.
> Please re-flow for 72/75 character line length.

Done

https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG@13 
PS7, Line 13: Auto-Generated
> Auto-generated …

Done

https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG@13 
PS7, Line 13: (Auto-Generated by create_coreboot_variant.sh version 3.0.0).
> Please remove the brackets ().

Done

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee... 
PS8, Line 4: SPD_SOURCES =
> Okay sounds good.

Thanks for the explanation.
We will re-visit here when we need to add SPD files.

[Frank Wu (Code Review)]

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 9:

Hi Google,

The comments are resolved.
Would you help review the CL again?
Thank you.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 9: Code-Review+2

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 9: Code-Review+2

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 9: Code-Review+2

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39667/9/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39667/9/src/mainboard/google/voltee... 
PS9, Line 5: 
are you missing gpio.c here?

[Frank Wu (Code Review)]

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39667/9/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39667/9/src/mainboard/google/voltee... 
PS9, Line 5:
> are you missing gpio. […]

The gpio.c is empty for halvor variant creating.
It is not used for now.
I am working on gpio modification for halvor and will push the CL later.

Should I update the makefile in this init CL?
Thank you.

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39667/9/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39667/9/src/mainboard/google/voltee... 
PS9, Line 5:
> The gpio.c is empty for halvor variant creating. […]

yes, please keep the makefile consistent with the files being added.

[Frank Wu (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Angel Pons, Marco Chen, Nick Vaccaro, Srinidhi N Kaushik, EricR Lai,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39667

to look at the new patch set (#10).

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference board by copying the
template files to a new directory named for the variant.

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
A src/mainboard/google/volteer/variants/halvor/gpio.c
A src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
A src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
A src/mainboard/google/volteer/variants/halvor/overridetree.cb
7 files changed, 77 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39667/10

[Frank Wu (Code Review)]

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 10:

(1 comment)

Hi Google,

Could you help review again?
Thank you.
Updated the Makefile.

https://review.coreboot.org/c/coreboot/+/39667/9/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39667/9/src/mainboard/google/voltee... 
PS9, Line 5:
> yes, please keep the makefile consistent with the files being added.

Done, I appreciate your advise.

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 10: Code-Review+1

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 10: Code-Review+2

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 10: Code-Review+2

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

Patch Set 10: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39667 )

Change subject: volteer: Create halvor variant
......................................................................

volteer: Create halvor variant

Create the halvor variant of the volteer reference board by copying the
template files to a new directory named for the variant.

BUG=b:151399850
BRANCH=None
TEST=util/abuild/abuild -p none -t google/volteer -x -a
make sure the build includes GOOGLE_HALVOR

Signed-off-by: Frank Wu 
Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39667
Tested-by: build bot (Jenkins) 
Reviewed-by: Caveh Jalali 
Reviewed-by: EricR Lai 
Reviewed-by: Paul Fagerburg 
Reviewed-by: Nick Vaccaro 
---
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/volteer/Kconfig.name
A src/mainboard/google/volteer/variants/halvor/Makefile.inc
A src/mainboard/google/volteer/variants/halvor/gpio.c
A src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
A src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
A src/mainboard/google/volteer/variants/halvor/overridetree.cb
7 files changed, 77 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nick Vaccaro: Looks good to me, approved
  Caveh Jalali: Looks good to me, but someone else must approve
  EricR Lai: Looks good to me, approved
  Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index 5bc4876..54a8fec 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -55,6 +55,7 @@

config MAINBOARD_PART_NUMBER
    string
+	default "Halvor" if BOARD_GOOGLE_HALVOR
    default "Ripto" if BOARD_GOOGLE_RIPTO
    default "Volteer" if BOARD_GOOGLE_VOLTEER

@@ -68,6 +69,7 @@

config VARIANT_DIR
    string
+	default "halvor" if BOARD_GOOGLE_HALVOR
    default "ripto" if BOARD_GOOGLE_RIPTO
    default "volteer" if BOARD_GOOGLE_VOLTEER

diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name
index d60dfb4..596894e 100644
--- a/src/mainboard/google/volteer/Kconfig.name
+++ b/src/mainboard/google/volteer/Kconfig.name
@@ -1,9 +1,13 @@
 comment "Volteer"

-config BOARD_GOOGLE_VOLTEER
-	bool "-> Volteer"
+config BOARD_GOOGLE_HALVOR
+	bool "-> Halvor"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER

config BOARD_GOOGLE_RIPTO
    bool "-> Ripto"
    select BOARD_GOOGLE_BASEBOARD_VOLTEER
+
+config BOARD_GOOGLE_VOLTEER
+	bool "-> Volteer"
+	select BOARD_GOOGLE_BASEBOARD_VOLTEER
diff --git a/src/mainboard/google/volteer/variants/halvor/Makefile.inc b/src/mainboard/google/volteer/variants/halvor/Makefile.inc
new file mode 100644
index 0000000..a115fcc
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/halvor/Makefile.inc
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier: GPL-2.0-only
+# This file is part of the coreboot project.
+
+SPD_SOURCES =
+
+bootblock-y += gpio.c
+
+ramstage-y += gpio.c
diff --git a/src/mainboard/google/volteer/variants/halvor/gpio.c b/src/mainboard/google/volteer/variants/halvor/gpio.c
new file mode 100644
index 0000000..6c4fb52
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/halvor/gpio.c
@@ -0,0 +1,37 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */
+
+#include <baseboard/gpio.h>
+#include <baseboard/variants.h>
+#include <commonlib/helpers.h>
+
+/* Pad configuration in ramstage */
+static const struct pad_config gpio_table[] = {
+
+};
+
+const struct pad_config *variant_base_gpio_table(size_t *num)
+{
+	*num = ARRAY_SIZE(gpio_table);
+	return gpio_table;
+}
+
+/* Early pad configuration in bootblock */
+static const struct pad_config early_gpio_table[] = {
+
+};
+
+const struct pad_config *variant_early_gpio_table(size_t *num)
+{
+	*num = ARRAY_SIZE(early_gpio_table);
+	return early_gpio_table;
+}
+
+static const struct cros_gpio cros_gpios[] = {
+};
+
+const struct cros_gpio *variant_cros_gpios(size_t *num)
+{
+	*num = ARRAY_SIZE(cros_gpios);
+	return cros_gpios;
+}
diff --git a/src/mainboard/google/volteer/variants/halvor/include/variant/ec.h b/src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
new file mode 100644
index 0000000..33e7971
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/halvor/include/variant/ec.h
@@ -0,0 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */
+
+#ifndef __VARIANT_EC_H__
+#define __VARIANT_EC_H__
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h b/src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
new file mode 100644
index 0000000..55725ad
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */
+
+#ifndef VARIANT_GPIO_H
+#define VARIANT_GPIO_H
+
+#include <baseboard/gpio.h>
+
+/* Copied from baseboard and may need to change for the new variant. */
+
+#endif
diff --git a/src/mainboard/google/volteer/variants/halvor/overridetree.cb b/src/mainboard/google/volteer/variants/halvor/overridetree.cb
new file mode 100644
index 0000000..75422d8
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/halvor/overridetree.cb
@@ -0,0 +1,4 @@
+chip soc/intel/tigerlake
+	device domain 0 on
+	end
+end