Attention is currently required from: Werner Zeh.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54913?usp=email )
Change subject: lib/rtc: Add sanity check for time and date
......................................................................
Patch Set 3:
(1 comment)
File src/lib/rtc.c:
https://review.coreboot.org/c/coreboot/+/54913/comment/3f8496ea_2fc3ea71 :
PS3, Line 129: month == 2
First leap year and we already hit this off-by-one error 😊
Month is passed as 0-based, not 1-based.
This is quite critical as it may break certificates, file systems, etc.
CB:80790
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54913?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a381d445c894eee4f82b50fe86dad22cc587605
Gerrit-Change-Number: 54913
Gerrit-PatchSet: 3
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Jan Dabros
jsd@semihalf.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 29 Feb 2024 10:53:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment