Attention is currently required from: Martin L Roth, Michał Żygowski, Paul Menzel.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75286?usp=email )
Change subject: drivers/intel/dtbt: Add discrete Thunderbolt driver ......................................................................
Patch Set 6:
(4 comments)
File src/drivers/intel/dtbt/Kconfig:
https://review.coreboot.org/c/coreboot/+/75286/comment/7add1ad6_1add416b : PS5, Line 2: bool : default n
Not a requirement, but you could use `def_bool n` here to replace these two lines.
Done
File src/drivers/intel/dtbt/dtbt.c:
https://review.coreboot.org/c/coreboot/+/75286/comment/84ce56fa_20c994b2 : PS2, Line 36: }
Yeah, those are handy functions. […]
Done
File src/drivers/intel/dtbt/dtbt.c:
https://review.coreboot.org/c/coreboot/+/75286/comment/62d0385f_77916a3e : PS5, Line 63: printk(BIOS_ERR, "DTBT device invalid\n")
I see a lot of cases where `dev` is dereferenced without checking. […]
Looks like it is. Dropped the check.
https://review.coreboot.org/c/coreboot/+/75286/comment/e6ef7657_2800455d : PS5, Line 69: printk(BIOS_ERR, "DTBT bus invalid\n");
This one probably wants a return as well.
Done