Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37714 )
Change subject: mb/google/auron: add VBTs for variants ......................................................................
mb/google/auron: add VBTs for variants
Add VBTs for all auron variants, extracted from VGA BIOS from stock firmware images using intelvbttool, zero-padded to 0x11ff bytes to make the Intel BMP editor happy.
Test: boot several auron variants with libgfxinit and Tianocore payload, ensure both internal and external displays as well as HDMI audio function properly under Linux (4.x/5.x).
Change-Id: Ibc4eabfa5d02b4c08755cf52835b5df8c1291fea Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/auron/Kconfig A src/mainboard/google/auron/variants/auron_paine/data.vbt A src/mainboard/google/auron/variants/auron_yuna/data.vbt A src/mainboard/google/auron/variants/buddy/data.vbt A src/mainboard/google/auron/variants/gandof/data.vbt A src/mainboard/google/auron/variants/lulu/data.vbt A src/mainboard/google/auron/variants/samus/data.vbt 7 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/37714/1
diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index b64b47e..644104a 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -8,6 +8,7 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM diff --git a/src/mainboard/google/auron/variants/auron_paine/data.vbt b/src/mainboard/google/auron/variants/auron_paine/data.vbt new file mode 100644 index 0000000..a73fb49 --- /dev/null +++ b/src/mainboard/google/auron/variants/auron_paine/data.vbt Binary files differ diff --git a/src/mainboard/google/auron/variants/auron_yuna/data.vbt b/src/mainboard/google/auron/variants/auron_yuna/data.vbt new file mode 100644 index 0000000..a73fb49 --- /dev/null +++ b/src/mainboard/google/auron/variants/auron_yuna/data.vbt Binary files differ diff --git a/src/mainboard/google/auron/variants/buddy/data.vbt b/src/mainboard/google/auron/variants/buddy/data.vbt new file mode 100644 index 0000000..400ea48 --- /dev/null +++ b/src/mainboard/google/auron/variants/buddy/data.vbt Binary files differ diff --git a/src/mainboard/google/auron/variants/gandof/data.vbt b/src/mainboard/google/auron/variants/gandof/data.vbt new file mode 100644 index 0000000..f95f4dd --- /dev/null +++ b/src/mainboard/google/auron/variants/gandof/data.vbt Binary files differ diff --git a/src/mainboard/google/auron/variants/lulu/data.vbt b/src/mainboard/google/auron/variants/lulu/data.vbt new file mode 100644 index 0000000..00bc088 --- /dev/null +++ b/src/mainboard/google/auron/variants/lulu/data.vbt Binary files differ diff --git a/src/mainboard/google/auron/variants/samus/data.vbt b/src/mainboard/google/auron/variants/samus/data.vbt new file mode 100644 index 0000000..4b079bc --- /dev/null +++ b/src/mainboard/google/auron/variants/samus/data.vbt Binary files differ
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37714 )
Change subject: mb/google/auron: add VBTs for variants ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37714 )
Change subject: mb/google/auron: add VBTs for variants ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37714 )
Change subject: mb/google/auron: add VBTs for variants ......................................................................
mb/google/auron: add VBTs for variants
Add VBTs for all auron variants, extracted from VGA BIOS from stock firmware images using intelvbttool, zero-padded to 0x11ff bytes to make the Intel BMP editor happy.
Test: boot several auron variants with libgfxinit and Tianocore payload, ensure both internal and external displays as well as HDMI audio function properly under Linux (4.x/5.x).
Change-Id: Ibc4eabfa5d02b4c08755cf52835b5df8c1291fea Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37714 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/auron/Kconfig A src/mainboard/google/auron/variants/auron_paine/data.vbt A src/mainboard/google/auron/variants/auron_yuna/data.vbt A src/mainboard/google/auron/variants/buddy/data.vbt A src/mainboard/google/auron/variants/gandof/data.vbt A src/mainboard/google/auron/variants/lulu/data.vbt A src/mainboard/google/auron/variants/samus/data.vbt 7 files changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index b64b47e..644104a 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -8,6 +8,7 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM diff --git a/src/mainboard/google/auron/variants/auron_paine/data.vbt b/src/mainboard/google/auron/variants/auron_paine/data.vbt new file mode 100644 index 0000000..a73fb49 --- /dev/null +++ b/src/mainboard/google/auron/variants/auron_paine/data.vbt Binary files differ diff --git a/src/mainboard/google/auron/variants/auron_yuna/data.vbt b/src/mainboard/google/auron/variants/auron_yuna/data.vbt new file mode 100644 index 0000000..a73fb49 --- /dev/null +++ b/src/mainboard/google/auron/variants/auron_yuna/data.vbt Binary files differ diff --git a/src/mainboard/google/auron/variants/buddy/data.vbt b/src/mainboard/google/auron/variants/buddy/data.vbt new file mode 100644 index 0000000..400ea48 --- /dev/null +++ b/src/mainboard/google/auron/variants/buddy/data.vbt Binary files differ diff --git a/src/mainboard/google/auron/variants/gandof/data.vbt b/src/mainboard/google/auron/variants/gandof/data.vbt new file mode 100644 index 0000000..f95f4dd --- /dev/null +++ b/src/mainboard/google/auron/variants/gandof/data.vbt Binary files differ diff --git a/src/mainboard/google/auron/variants/lulu/data.vbt b/src/mainboard/google/auron/variants/lulu/data.vbt new file mode 100644 index 0000000..00bc088 --- /dev/null +++ b/src/mainboard/google/auron/variants/lulu/data.vbt Binary files differ diff --git a/src/mainboard/google/auron/variants/samus/data.vbt b/src/mainboard/google/auron/variants/samus/data.vbt new file mode 100644 index 0000000..4b079bc --- /dev/null +++ b/src/mainboard/google/auron/variants/samus/data.vbt Binary files differ
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)