Evan Lojewski has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37160 )
Change subject: makedpfw: Fix the example command line to use the proper files ......................................................................
makedpfw: Fix the example command line to use the proper files
The makedpfw example command contradicts the usage in makechips.sh This fixed the help text to match the script and to use the correct names as provided in Windows pacakge.
Signed-off-by: Evan Lojewski github@meklort.com Change-Id: I897584b58904ca3c2c6cab567ed8bce2d6d4afb0 --- M makedpfw.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/60/37160/1
diff --git a/makedpfw.c b/makedpfw.c index 97dfe15..2973f75 100644 --- a/makedpfw.c +++ b/makedpfw.c @@ -62,7 +62,7 @@ static void usage(char *name) { printf("makedpfw: EM100pro firmware update maker\n\nExample:\n" - " %s -m 1.bin -M 2.27 -f 2.bin -F 0.85 -o \n" + " %s -m 2.bin -M 2.27 -f 1.bin -F 0.85 -o \n" "\nUsage:\n" " -m|--mcu-file <file> MCU firmware file name\n" " -M|--mcu-version <version> MCU firmware version\n"
Evan Lojewski has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37160 )
Change subject: makedpfw: Fix the example command line to use the proper files ......................................................................
Patch Set 1:
This changes fixed the example text that can easily cause someone to brick an em100pro due to flashing and incorrect .dpfw file just by following the example command...
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37160 )
Change subject: makedpfw: Fix the example command line to use the proper files ......................................................................
Patch Set 1: Code-Review+2
Thank you, Evan!
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37160 )
Change subject: makedpfw: Fix the example command line to use the proper files ......................................................................
makedpfw: Fix the example command line to use the proper files
The makedpfw example command contradicts the usage in makechips.sh This fixed the help text to match the script and to use the correct names as provided in Windows pacakge.
Signed-off-by: Evan Lojewski github@meklort.com Change-Id: I897584b58904ca3c2c6cab567ed8bce2d6d4afb0 Reviewed-on: https://review.coreboot.org/c/em100/+/37160 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M makedpfw.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
diff --git a/makedpfw.c b/makedpfw.c index 97dfe15..2973f75 100644 --- a/makedpfw.c +++ b/makedpfw.c @@ -62,7 +62,7 @@ static void usage(char *name) { printf("makedpfw: EM100pro firmware update maker\n\nExample:\n" - " %s -m 1.bin -M 2.27 -f 2.bin -F 0.85 -o \n" + " %s -m 2.bin -M 2.27 -f 1.bin -F 0.85 -o \n" "\nUsage:\n" " -m|--mcu-file <file> MCU firmware file name\n" " -M|--mcu-version <version> MCU firmware version\n"
-
Evan Lojewski (Code Review) -
Stefan Reinauer (Code Review)