Attention is currently required from: Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik.
Kapil Porwal has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85025?usp=email )
Change subject: soc/intel/cmn/pmc: Perform PM register init for CSE
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/85025/comment/fd20de64_fb3a5259?usp... :
PS2, Line 494: /* Clear pending SLP_TYP */
: pmc_write_pm1_control(ps->pm1_cnt & ~(SLP_TYP));
@kramasub@google.com and @subratabanik@google.com
I think, we do not need to clear the sleep type here since we got here due to the same reason (SLP_TYP being 0). WDYT?
we can also avoid line#497.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85025?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae9c026da86fef4a3571e06b1bb20504c3d8c9be
Gerrit-Change-Number: 85025
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 11 Nov 2024 08:23:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No