Change in ...coreboot[master]: soc/intel/broadwell: Use C_ENVIRONMENT_BOOTBLOCK - coreboot-gerrit

15 May 2019


      Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30383 )
Change subject: soc/intel/broadwell: Use C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 48:
(1 comment)
https://review.coreboot.org/#/c/30383/48/src/soc/intel/broadwell/romstage/ro... 
File src/soc/intel/broadwell/romstage/romstage.c:
https://review.coreboot.org/#/c/30383/48/src/soc/intel/broadwell/romstage/ro... 
PS48, Line 72:
...
Losing the initialization of `pei_data` here. Maybe memset() the […]
nice catch, that seems to have been the issue :)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30383
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44eb6d380dea5b82e3f009a46381a0f611bb7935
Gerrit-Change-Number: 30383
Gerrit-PatchSet: 48
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 May 2019 03:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment