Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45712 )
Change subject: nb/intel/haswell: Account for DPR region in memory map
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45712/10/src/northbridge/intel/hasw...
File src/northbridge/intel/haswell/northbridge.c:
https://review.coreboot.org/c/coreboot/+/45712/10/src/northbridge/intel/hasw...
PS10, Line 339: resource->base = (dpr.top - dpr.size) << 10;
: resource->size = (dpr.size << 10);
this needs to be in bytes
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45712
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11f23fd43188f987e35fd61f52587e567496cd78
Gerrit-Change-Number: 45712
Gerrit-PatchSet: 12
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 14 Oct 2020 18:11:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment