Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Julius Werner, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66943 )
Change subject: Add first BIOS block in coreboot.pre
......................................................................
Patch Set 7:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/66943/comment/c30ef9a4_17346c98
PS7, Line 1112: FIRST_BIOS_BLOCK=$(objcbfs)/bootblock.bin
: ifeq ($(CONFIG_AMDFW_CONTAINS_FIRST_BIOS_BLOCK),y)
: FIRST_BIOS_BLOCK=$(obj)/amdfw.rom
: add_firstbiosblock = \
: $(CBFSTOOL) $(1) add -f $(2) -n apu/amdfw -t amdfw \
: -b $(call int-add, \
: $(call int-subtract, 0xffffffff \
: $(call int-shift-left, \
: 0x80000 $(CONFIG_AMD_FWM_POSITION_INDEX))) 0x20000 1)
: endif # ifeq ($(CONFIG_AMDFW_CONTAINS_FIRST_BIOS_BLOCK),y)
Add this somewhere in soc/amd ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66943
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4d1a2d8b145cbbbf2da27aa73b296c9c8a65209
Gerrit-Change-Number: 66943
Gerrit-PatchSet: 7
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 08 Oct 2022 09:46:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment