Attention is currently required from: Hung-Te Lin, Jiaxin Yu, Yang Wu, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79064?usp=email )
Change subject: mb/google/corsola/var/chinchou: Configure I2C and I2S interface for ALC5650
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/corsola/mainboard.c:
https://review.coreboot.org/c/coreboot/+/79064/comment/6b02e597_898a814d :
PS9, Line 16: audio
Can we rename this to be more specific?
configure_alc1019
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79064?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854
Gerrit-Change-Number: 79064
Gerrit-PatchSet: 9
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jiaxin Yu
jiaxin.yu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jiaxin Yu
jiaxin.yu@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 16 Nov 2023 08:35:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment