Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 3:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/1ad154fa_b7390aa4 PS3, Line 101: if(CONFIG(TROGDOR_HAS_MIPI_PANEL)) space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/9490028a_63a4ba68 PS3, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/489fe61d_0ac69fe5 PS3, Line 172: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/36d3e989_803777e3 PS3, Line 210: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/e1737f05_55bfdde0 PS3, Line 281: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/97c52214_6962d0ef PS3, Line 289: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/9487c056_39cfb244 PS3, Line 292: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/a9a51ecb_966f2413 PS3, Line 299: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/a8f9f481_3ce4375e PS3, Line 302: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/51adebd5_61557fc5 PS3, Line 319: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/92b618e0_ace35fa0 PS3, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/151cdaf9_f122e87d PS3, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/a13ab787_9d5fd195 PS3, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/cc37c4f7_864463de PS3, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013): https://review.coreboot.org/c/coreboot/+/52662/comment/06424a0a_cac68b4f PS3, Line 343: if(!pinfo && !pinfo->init_cmd) space required before the open parenthesis '('