Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: soc/ibexpeak: Use .device for single PCI ID ......................................................................
soc/ibexpeak: Use .device for single PCI ID
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I40c4447579cfbf2b9c52dcfaa34f34b22f75c89c --- M src/southbridge/intel/ibexpeak/thermal.c 1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/39332/1
diff --git a/src/southbridge/intel/ibexpeak/thermal.c b/src/southbridge/intel/ibexpeak/thermal.c index 4b6e1dd..b6365da 100644 --- a/src/southbridge/intel/ibexpeak/thermal.c +++ b/src/southbridge/intel/ibexpeak/thermal.c @@ -57,13 +57,8 @@ .ops_pci = &pci_ops, };
-static const unsigned short pci_device_ids[] = { - PCI_DID_INTEL_IBEXPEAK_THERMAL, - 0 -}; - static const struct pci_driver pch_thermal __pci_driver = { .ops = &thermal_ops, .vendor = PCI_VID_INTEL, - .devices = pci_device_ids, + .device = PCI_DID_INTEL_IBEXPEAK_THERMAL, };
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39332
to look at the new patch set (#2).
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
sb/ibexpeak: Use .device for single PCI ID
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I40c4447579cfbf2b9c52dcfaa34f34b22f75c89c --- M src/include/device/pci_ids.h M src/southbridge/intel/ibexpeak/thermal.c 2 files changed, 4 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/39332/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 3: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
I don't think there is much to gain from doing this, or am I mistaken?
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/thermal.c:
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... PS3, Line 63: .device = PCI_DID_INTEL_IBEXPEAK_THERMAL, What if another thermal device ID appears that can be handled by the same driver?
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3: Code-Review-1
I don't think there is much to gain from doing this, or am I mistaken?
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/thermal.c:
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... PS3, Line 63: .device = PCI_DID_INTEL_IBEXPEAK_THERMAL,
What if another thermal device ID appears that can be handled by the same driver?
Just a little code clean up. If there appears another device ID as you said, then we can revert/undo this change, because it's not much work. As long as there is only this device ID I see no reason why we should use .devices instead of .device.
It is also used at other places, so it just makes sense moving to .device to keep the consistency. Otherwise we should move everything else to .devices.
Hello build bot (Jenkins), Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner, Patrick Rudolph, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39332
to look at the new patch set (#4).
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
sb/ibexpeak: Use .device for single PCI ID
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I40c4447579cfbf2b9c52dcfaa34f34b22f75c89c --- M src/southbridge/intel/ibexpeak/thermal.c 1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/39332/4
Hello build bot (Jenkins), Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner, Patrick Rudolph, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39332
to look at the new patch set (#5).
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
sb/ibexpeak: Use .device for single PCI ID
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I40c4447579cfbf2b9c52dcfaa34f34b22f75c89c --- M src/southbridge/intel/ibexpeak/thermal.c 1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/39332/5
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/thermal.c:
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... PS3, Line 63: .device = PCI_DID_INTEL_IBEXPEAK_THERMAL,
Just a little code clean up. […]
Any more opinions on this here?
Hello build bot (Jenkins), Nico Huber, Paul Menzel, Angel Pons, Michael Niewöhner, Patrick Rudolph, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39332
to look at the new patch set (#6).
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
sb/ibexpeak: Use .device for single PCI ID
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I40c4447579cfbf2b9c52dcfaa34f34b22f75c89c --- M src/southbridge/intel/ibexpeak/thermal.c 1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/39332/6
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 6: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/thermal.c:
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... PS3, Line 63: .device = PCI_DID_INTEL_IBEXPEAK_THERMAL,
Any more opinions on this here?
Ack
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 6: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 7: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
sb/ibexpeak: Use .device for single PCI ID
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I40c4447579cfbf2b9c52dcfaa34f34b22f75c89c Reviewed-on: https://review.coreboot.org/c/coreboot/+/39332 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/ibexpeak/thermal.c 1 file changed, 1 insertion(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/southbridge/intel/ibexpeak/thermal.c b/src/southbridge/intel/ibexpeak/thermal.c index 298016f..df261de 100644 --- a/src/southbridge/intel/ibexpeak/thermal.c +++ b/src/southbridge/intel/ibexpeak/thermal.c @@ -43,13 +43,8 @@ .ops_pci = &pci_ops, };
-static const unsigned short pci_device_ids[] = { - PCI_DID_INTEL_IBEXPEAK_THERMAL, - 0 -}; - static const struct pci_driver pch_thermal __pci_driver = { .ops = &thermal_ops, .vendor = PCI_VENDOR_ID_INTEL, - .devices = pci_device_ids, + .device = PCI_DID_INTEL_IBEXPEAK_THERMAL, };
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 8:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2191 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2190 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2189
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Felix Singer (Code Review)
-
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)