[S] Change in coreboot[main]: util/superiotool/ite: Add extra dumps for IT8613E EC

[Felix Singer (Code Review)]

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80318?usp=email )

Change subject: util/superiotool/ite: Add extra dumps for IT8613E EC
......................................................................

util/superiotool/ite: Add extra dumps for IT8613E EC

IT8613E EC space is divided into 3 banks selectable by EC index 0x06
bits 6:5. Bank0 mostly contains the ITE EC registers known by
coreboot's ITE EC driver. Bank1 contains SB_TSI and PECI temperature
reading registers. Bank2, however, contains additional registers used
to select the temperature source reported in TMPIN reading registers,
PECI bridge registers as well as FAN2-5 controls and extra vectors.

Dump the additional banks using extra-selectors.

Based on non-public IT8613E Preliminary Specification V0.3.

TEST=Perform the IT8613E dump on Hardkernel ODROID H4+.

Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6
Signed-off-by: Michał Żygowski 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80318
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Singer 
Reviewed-by: Maxim 
Reviewed-by: Alicja Michalska 
Reviewed-by: Angel Pons 
Reviewed-by: Marvin Drees 
---
M util/superiotool/ite.c
1 file changed, 42 insertions(+), 2 deletions(-)

Approvals:
  Felix Singer: Looks good to me, approved
  Alicja Michalska: Looks good to me, but someone else must approve
  Maxim: Looks good to me, but someone else must approve
  Marvin Drees: Looks good to me, but someone else must approve
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, but someone else must approve

diff --git a/util/superiotool/ite.c b/util/superiotool/ite.c
index 91decc6..22b5620 100644
--- a/util/superiotool/ite.c
+++ b/util/superiotool/ite.c
@@ -7,6 +7,15 @@
 #define CHIP_VERSION_REG	0x22
 #define ISA_PNP_ADDR		0x279

+/* IT8613 EC SMI# Mask Register 3 (06h): BANK_SEL[6-5] */
+#define IT8613_EC_BANK_SEL(bank) 			\
+	{						\
+		.idx = 0x06,				\
+		.mask = 0x60,				\
+		.val = (((bank) & 3) << 5)		\
+	}
+
+
 static const struct superio_registers reg_table[] = {
    {0x5570, "IT5570E", {
    	{NOLDN, NULL,
@@ -1380,7 +1389,7 @@

static const struct superio_registers ec_table[] = {
    {0x8613, "IT8613E", {
-		{NOLDN, NULL,
+		{NOLDN, "BANK0",
    		{0x00,0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08,0x09,
    		 0x0a,0x0b,0x0c,0x0e,0x0f,0x11,0x12,0x13,0x14,0x16,
    		 0x17,0x19,0x1a,0x1c,0x1d,0x1e,0x1f,0x20,0x21,0x22,
@@ -1408,7 +1417,38 @@
    		 NANA,NANA,NANA,NANA,0x00,0x00,0x00,0x00,0x00,0x00,
    		 0x00,MISC,0x00,0x00,0x00,0x00,0x00,NANA,0x00,NANA,
    		 0x7f,0x7f,0x7f,0x00,0x00,0x7f,0x0f,NANA,NANA,NANA,
-			 NANA,NANA,NANA,EOT}},
+			 NANA,NANA,NANA,EOT},
+			 IT8613_EC_BANK_SEL(0)},
+		{NOLDN, "BANK1",
+			{0xc0,0xc1,0xc2,0xd0,0xd1,0xd2,0xd3,0xd4,0xd5,0xd6,
+			 0xd7,0xd8,0xd9,0xda,0xdb,0xdc,0xe0,0xe1,0xe2,0xe3,
+			 0xe4,0xe5,0xe6,0xe7,0xe8,0xe9,0xea,0xeb,0xec,0xed,
+			 0xee,0xef,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,0xf7,
+			 0xf8,0xf9,0xfa,0xfb,0xfc,0xfd,0xfe,0xff,EOT},
+			{0x00,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,EOT},
+			 IT8613_EC_BANK_SEL(1)},
+		{NOLDN, "BANK2",
+			{0x1d,0x1e,0x1f,0x20,0x21,0x22,0x23,0x24,0x25,0x26,
+			 0x27,0x28,0x29,0x2a,0x2b,0x2c,0x30,0x31,0x32,0x33,
+			 0x34,0x35,0x36,0x37,0x38,0x39,0x3a,0x3b,0x3c,0x3d,
+			 0x40,0x41,0x42,0x43,0x44,0x45,0x46,0x47,0x48,0x49,
+			 0x4a,0x4b,0x4c,0x4d,0x50,0x51,0x52,0x53,0x54,0x55,
+			 0x56,0x57,0x58,0x59,0x5a,0x5b,0x5c,0x5d,0x5e,0x5f,
+			 0x6d,0x6e,0x6f,0x70,0x71,0x72,0x73,0x74,0x75,0x76,
+			 EOT},
+			{0x00,0x00,0x00,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,0x00,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,0x00,0x00,0x00,
+			 0x00,0x00,0x00,NANA,NANA,0x00,NANA,NANA,NANA,NANA,
+			 EOT},
+			 IT8613_EC_BANK_SEL(2)},
    	{EOT}}},
    {0x8625, "IT8625E", {
    	{NOLDN, NULL,